Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/denied-tool-reason-key.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@truefoundry/trueforge-assistant-ui-runtime': patch
---

Show a denied tool call's result as `reason` instead of `error`.
2 changes: 1 addition & 1 deletion packages/assistant-ui-runtime/src/modelMessageContent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ function toolCallToPart(toolCall: SdkToolCall, context?: ToolCallContext): ToolC
result = toolResult === '' ? true : toolResult;
} else if (approvalDecision?.approved === false) {
result = {
error:
reason:
approvalDecision.reason == null || approvalDecision.reason.length === 0
? 'Tool approval denied'
: approvalDecision.reason,
Expand Down
2 changes: 1 addition & 1 deletion packages/assistant-ui-runtime/src/toolApproval.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ function applyApprovalDecisionToToolCall(
return {
...part,
approval,
result: { error: reason ?? 'Tool approval denied' },
result: { reason: reason ?? 'Tool approval denied' },
isError: true,
};
}
Expand Down
4 changes: 2 additions & 2 deletions packages/assistant-ui-runtime/test/foldPeerThreads.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -735,7 +735,7 @@ describe('foldPeerThreads', () => {
expect(state.ingestedEventIds).toEqual(new Set(['mcp-continue-1', 'policy-1']));
});

it('recordToolApprovalInFold synthesizes an error result on deny', () => {
it('recordToolApprovalInFold synthesizes a reason result on deny', () => {
const state = seedPendingApproval();

recordToolApprovalInFold(state, {
Expand All @@ -753,7 +753,7 @@ describe('foldPeerThreads', () => {
}
expect(toolCall.approval?.approved).toBe(false);
expect(toolCall.isError).toBe(true);
expect(toolCall.result).toEqual({ error: 'not allowed' });
expect(toolCall.result).toEqual({ reason: 'not allowed' });
});

it('gives create_sub_agent a truthy result after empty tool.response so aui marks it complete', () => {
Expand Down
Loading