Repository navigation
fix : tool call result handling to display denied tool reasons - #1397
Merged
harshil-2096 merged 3 commits intoNov 16, 2026
Merged
Conversation
harshil-2096
requested review from
govindavashishtha,
kumarsks619,
qaifi-tf,
sajal-truefoundry,
sayan-truefoundry and
vinit-truefoundry
as code owners
November 16, 2026 11:34
🦋 Changeset detectedLatest commit: 2c13e4a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…son instead of error on denial
govindavashishtha
approved these changes
Nov 16, 2026
harshil-2096
enabled auto-merge (squash)
November 16, 2026 11:56
harshil-2096
deleted the
bugfix/hv/tool-call-denial-reason-appears-as-an-error
branch
November 16, 2026 12:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes AGE-2797
Changes
How was this tested?
Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,python/trueforge_sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Low Risk
Narrow UI payload shape change in assistant-ui-runtime;
isErrorbehavior is unchanged.Overview
Denied tool approvals now synthesize tool-call results with a
reasonfield instead oferror, so the assistant UI can show the denial explanation in the right place. The default message remainsTool approval deniedwhen no reason is provided.This is applied consistently when building assistant content from approval decisions (
modelMessageContent) and when recording a deny in the peer-thread fold (toolApproval). The fold test expectation was updated to match.Reviewed by Cursor Bugbot for commit 2c13e4a. Bugbot is set up for automated code reviews on this repo. Configure here.