Repository navigation
Fix concurrent approvals and mcp auth required state on UI - #1365
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
chiragjn
requested review from
debajyoti-truefoundry,
govindavashishtha,
heerambavi1998,
kumarsks619,
qaifi-tf,
sajal-truefoundry,
sayan-truefoundry,
thesujai and
vinit-truefoundry
as code owners
November 12, 2026 13:55
🦋 Changeset detectedLatest commit: 500859d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 89b6c4e. Configure here.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Nov 12, 2026
truefoundry-saas
added a commit
that referenced
this pull request
Nov 12, 2026
* chore(deps-dev): bump vite from 6.4.4 to 6.4.5 in the npm-security group across 1 directory (#1316) Bumps the npm-security group with 1 update in the / directory: [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite). Updates `vite` from 6.4.4 to 6.4.5 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v6.4.5/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v6.4.5/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 6.4.5 dependency-type: direct:development dependency-group: npm-security ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ci: check migration order against PR base branch instead of main (#1336) Co-authored-by: TrueForge Agent <trueforge@example.org> * fix: apply create-time capability checks on agent update (#1335) Agent save is a publish boundary, so create and update must both reject disabled web search, memory, and sandbox environments. Sessions still grandfather stored specs so existing chats keep running without forcing an agent edit first. * [AGE-2739] Show why chat turns stopped after cancellation or errors (#1344) * Revert "bugfix: hide cancelled-turn reason banners in live chat (#1258)" This reverts commit 117b013. Co-authored-by: Cursor <cursoragent@cursor.com> * [AGE-2739] Show why chat turns stopped after cancellation or errors Map turn cancel reasons to readable banner text (stopped, timed out, interrupted) in chat and session detail. Hide only turns replaced by a newer message in live chat; session replay still shows them. Client-side supersede/cancel now use the wire cancel reasons so live and reloaded turns match. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com> * fix(deps): patch node-forge, follow-redirects, body-parser High CVEs (#1325) * fix(deps): override node-forge, follow-redirects, body-parser to patched versions * Upgrade jest and use pnpm up -r instead of overrides * Add changeset for dependency vulnerability and Jest bumps. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: tfy-vuln-bot <vuln-bot@truefoundry.com> Co-authored-by: Chirag Jain <jain.chirag925@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> * Backfill tfg.source metadata for schedule sessions (#1359) * Fix concurrent approvals and mcp auth required state on UI (#1365) * Docs for turn paused state * WIP: Enhance code snippets * Handle mcp auth required bug with concurrent approvals * Fix mcp auth required with concurrent approval in subagents * Dont' make mcp continue optimistic * Show Cancelling feedback and single-flight stop on the composer. Co-authored-by: Cursor <cursoragent@cursor.com> * Align assistant-ui-runtime tests with concurrent pause status rules. Co-authored-by: Cursor <cursoragent@cursor.com> * Keep sibling prompts interactive without inventing paused turnState. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com> * Regenerate OpenAPI document and SDKs * rename trueforge mcp and use same name as ID. (#1360) (cherry picked from commit bf57ece) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: TrueForge Agent <trueforge@example.org> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: tfy-vuln-bot <vuln-bot@truefoundry.com> Co-authored-by: Chirag Jain <jain.chirag925@gmail.com> Co-authored-by: trueforge-dev-bot[bot] <trueforge-dev-bot[bot]@users.noreply.github.com> Co-authored-by: Heer Ambavi <97429806+heerambavi1998@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Touches turn streaming, pause/resume, and composer state for multi-thread pauses; behavior is heavily tested but is user-facing chat flow logic.
Overview
Fixes concurrent pause behavior when parallel sub-agents need tool approval, ask-user/custom input, and MCP OAuth at the same time.
Runtime (
assistant-ui-runtime) now prioritizes tool-approval / response chrome over MCP Connect, keeps MCP metadata so Connect can appear as soon as the last approval clears, and stops clearing MCP auth or forcingpausedon siblingturn.updaterunning or later content. Resume cursors stay onmcp.auth_requireduntiluser.mcp_auth_continue(not merely running).withOptimisticMcpAuthContinueand a successful-onlycontinueMcpAuthpath clear Connect and show Working without a blank gap; cancel is deduped while in flight.UI (
trueforge-ui) matches that precedence inuseComposerPauseView, leaves ask-user / custom actions / MCP Continue usable when the thread is still “running”, hides MCP Continue after success, and shows Cancelling... on the composer stop button.Also adds large v2 SDK docs (
overview-v2,use-agent-v2) and minor comment tweaks in the legacy use-agent doc.Reviewed by Cursor Bugbot for commit 500859d. Bugbot is set up for automated code reviews on this repo. Configure here.