Repository navigation
[Cherry-pick] Cherry-pick to release-v0.185.0 - #1367
truefoundry-saas wants to merge 3 commits into
Conversation
* Docs for turn paused state * WIP: Enhance code snippets * Handle mcp auth required bug with concurrent approvals * Fix mcp auth required with concurrent approval in subagents * Dont' make mcp continue optimistic * Show Cancelling feedback and single-flight stop on the composer. Co-authored-by: Cursor <cursoragent@cursor.com> * Align assistant-ui-runtime tests with concurrent pause status rules. Co-authored-by: Cursor <cursoragent@cursor.com> * Keep sibling prompts interactive without inventing paused turnState. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: db5e24a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit db5e24a. Configure here.
| }, | ||
| parallelToolGroups, | ||
| ); | ||
| } |
There was a problem hiding this comment.
Terminal turns show stale approval chrome
Medium Severity
History projection now stamps approval or ask-user requires-action chrome whenever the fold still has a pending prompt, without checking that the turn is still paused or running. A cancelled or errored turn that died mid-approval can reload as if it still needs input, hiding the terminal state.
Reviewed by Cursor Bugbot for commit db5e24a. Configure here.
| }, | ||
| }, | ||
| }); | ||
| } |
There was a problem hiding this comment.
Continue skips Working after last approval
Medium Severity
withOptimisticMcpAuthContinue treats leftover toolApprovalThreadId / toolResponseThreadId on the message as “not MCP-only,” so it never flips the tip to running. Those keys stay on the message when MCP metadata is stashed beside approval chrome, and the approval overlay does not clear them. Approving the last tool then hitting Continue (the intended handoff) dismisses Connect without showing Working.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit db5e24a. Configure here.


Automated cherry-pick for release request
d91df53c-1f11-4bae-bbdc-ebf19125e5db.Source PRs (merged to main):
Warning
This PR does not contain the fix yet. The cherry-pick conflicted, so
automation stopped at the first conflicting commit and left the rest out.
GitHub therefore shows this PR as mergeable, with no conflict to resolve —
it carries only the 2 commit(s) that applied before the conflict.
Paste the prompt below into any coding agent that has this repository open.
It checks out this branch, applies the missing commits, and pushes.
Do not merge the PR. The release request checks every commit within a few
minutes (or use "Sync status" on it). The PR is merged when the request is
approved — or, if it is already approved, when a QA member or engineering
admin uses "Retry merge".
Agent prompt — copy from here:
Conflicting file(s):
packages/assistant-ui-runtime/src/collectPending.tspackages/assistant-ui-runtime/test/collectPending.test.tsCommits still to apply (starting at the conflict):
bf57ece2e8a6d442994f7df02d7a7c0f01ca45aeDo not merge manually — this PR is merged automatically when the release request is approved. If you do merge it yourself, use "Sync status" on the request so it stops showing as pending.
Note
Medium Risk
Changes live turn-stream → UI mapping and pause precedence in assistant-ui-runtime (high user impact), plus a one-way DB backfill for session metadata; both are heavily covered by new/updated tests.
Overview
Concurrent pauses (tool approval, ask-user, MCP auth) on parallel sub-agents now show tool-input chrome first, keep Connect / ask-user / custom actions usable while the turn is
running, and stop treating siblingturn.updaterunning as clearing MCP auth or forcing a boguspausedturnState. Resume cursors stay onmcp.auth_requireduntiluser.mcp_auth_continue. Continue clears Connect only after the API accepts it (withOptimisticMcpAuthContinueshows Working… without a blank gap); the MCP prompt dismisses on success to avoid double-clicks.The composer stop button shows Cancelling… while cancel is in flight (deduped via
cancelInFlightRef).Schedule runs stamp new sessions with
metadata['tfg.source'] = 'schedule'; Postgres and SQLite migrations backfill existing schedule-linked sessions for source counts.Adds large SDK v2 docs (
overview-v2.mdx,use-agent-v2.mdx), minoruse-agent.mdxsnippet tweaks, and bumps OpenAPI to 0.185.0-rc.3.Reviewed by Cursor Bugbot for commit db5e24a. Bugbot is set up for automated code reviews on this repo. Configure here.