Skip to content

fix(approval-flow): do not skip the polling interval #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snskArora merged 2 commits into from
Aug 28, 2026
Merged

fix(approval-flow): do not skip the polling interval #236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2eed608
fix(approval-flow): do not skip the polling interval
lowie27 Aug 21, 2026
716a535
Enhance comments for API call throttling logic
snskArora Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,12 @@ func newCommentLoopChannel(ctx context.Context, apprv *approvalEnvironment, clie
case approvalStatusPending:
if apprv.closeIssueMeansDenial {
// Loop counter to make an API call only once per 10 interation, intention: avoid github rate limiting and reduce api cost and stress.
// Throttle the issue-state check: Issues.Get runs once every 11 iterations to avoid GitHub rate limiting.
//
// This break exits the enclosing switch, NOT the for loop, so control falls through to the time.Sleep below and polling continues at the normal interval. Do not change it back to continue: continue is not captured by a switch, so it would jump straight to the next for iteration, skip the sleep, and issue 12 API calls per polling interval (see #235).
if loop_ctr < 10 {
loop_ctr += 1
continue
break
}
loop_ctr = 0

Expand Down