fix(approval-flow): do not skip the polling interval - #236
Merged
Merged
Conversation
lizziemac
previously approved these changes
Aug 21, 2026
Added comments to clarify throttling logic for API calls and control flow in the loop.
Collaborator
|
Note Today the eleven-iteration burst completes in roughly one interval, so a closed issue is noticed within ~10s at defaults |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #235
The
continuein the pending branch bypassedtime.Sleep, so withclose-issue-means-denialsetthe loop sent 12 API calls per
polling-interval-secondsinstead of 1.Measured against an
httpteststub with the realnewCommentLoopChannel, 1 second interval over5.5 seconds:
make testandmake lintpass locally (golangci-lint v2.10.1, 0 issues).The measurement is a Go test I can add in a follow-up if you want it; left out here to keep this to
one line.