Repository navigation
Remove unused transport switches - #91
Open
behinddwalls wants to merge 1 commit into
Open
behinddwalls wants to merge 1 commit into
behinddwalls wants to merge 1 commit into
Conversation
This was referenced Sep 30, 2026
behinddwalls
marked this pull request as ready for review
September 30, 2026 20:02
`server.http2` and `store.gcs.direct_connectivity` were accepted configuration values with no runtime consumers, so changing them gave operators a false impression that transport behavior changed. Remove both unsupported switches from the configuration surface and example file, and add a regression test proving the obsolete keys are rejected. ✅ `cargo test -p walgit-config removed_transport_switches_are_rejected` ✅ `cargo fmt --all -- --check` ✅ `git diff --check` Closes tobi#83
behinddwalls
force-pushed
the
preetam/issue-83-unused-config
branch
from
October 1, 2026 18:11
f8aca1d to
a200384
Compare
Contributor
nibzard
added a commit
to nibzard/walgit
that referenced
this pull request
Oct 14, 2026
Co-Authored-By: Claude Code <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
server.http2andstore.gcs.direct_connectivitywere accepted configuration values with no runtime consumers, so changing them gave operators a false impression that transport behavior changed.What?
Remove both unsupported switches from the configuration surface and example file, and add a regression test proving the obsolete keys are rejected.
Test Plan
✅
cargo test -p walgit-config removed_transport_switches_are_rejected✅
cargo fmt --all -- --check✅
git diff --checkIssue
Closes #83