Skip to content

Make skill instructions English-only and stop shipping examples - #205

Merged
titanwings merged 1 commit into
dot-skillfrom
skill-english-no-examples
Oct 12, 2026
Merged

titanwings merged 1 commit into
dot-skillfrom
skill-english-no-examples

Conversation

@titanwings

Copy link
Copy Markdown
Owner

Requested by Tianyi · project thread

Summary

The skill's instruction files are now English-only, and the example profiles are removed from the repo and ignored so they are not uploaded again.

Changes

  • SKILL.md: dropped the Chinese half and the "English Version" divider; the language note now says the instructions are in English and the agent replies in the user's language.
  • prompts/ and references/: translated all Chinese text to English (intake, persona/work analyzers and builders, merger, correction handler, plus small fragments in celebrity/owner prompts). Output-language lines now say "the user's language".
  • Removed skills/colleague/example_{zhangsan,tianyi,jiaxiu}/ and docs/examples/owner-discovery-e2e.md; .gitignore now ignores /skills/ and /docs/examples/.
  • Tests: the docs test now checks that SKILL.md, prompts and references contain no Han characters, and that the examples paths are ignored instead of present.
  • Unchanged on purpose: localized READMEs/ROADMAPs, INSTALL.md, docs/PRD.md, and Chinese strings in tools/ (generated skills still render in Chinese when the profile language is zh).

Motivation

Requested in the project thread: make the skill content English and stop committing examples.

Testing

  • python -m unittest discover -s tests -p 'test_*.py' passed (109 tests)
  • python -m compileall tools/ passed (no tools changed)
  • Manually tested

Checklist

  • I read CONTRIBUTING.md
  • Docs updated if behavior or usage changed (README / SKILL.md / INSTALL.md)
  • No secrets, tokens, or personal data committed
  • New dependencies added to requirements.txt (if any)
  • Tests added/updated for new functionality (or reason explained above)

🤖 Generated with Claude Code

https://claude.ai/code/session_01GNKjfDkCx5ozJ4oL69tgBo


Generated by Claude Code

SKILL.md now keeps only the English instructions and tells the agent to
reply in the user's language. Prompts and references are translated to
English. The example colleague profiles and the recorded e2e run are
removed and ignored.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GNKjfDkCx5ozJ4oL69tgBo
@titanwings titanwings self-assigned this Oct 12, 2026
@titanwings
titanwings merged commit ab0413f into dot-skill Oct 12, 2026
3 checks passed
titanwings pushed a commit that referenced this pull request Oct 13, 2026
…'s merges

- The English work_builder prompt (#205) words the Persona handoff as
  "outside the scope of responsibility", which the work-only filter did not
  match, so work_skill.md kept a pointer to a Persona section it lacks.
  Widen the English and Chinese patterns.
- #197 made self/yourself aliases of the new owner family, so generated
  skills whose stored meta says type "self" were renamed owner-<slug> on
  install. Stored skill metadata now maps owner back to relationship.
- owner_sources.py discover no longer crashes on a malformed MCP config
  (non-dict mcpServers, non-UTF-8 TOML/YAML).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018qsZs2yPoPC21GnGkktmwp
titanwings pushed a commit that referenced this pull request Oct 13, 2026
…'s merges

- The English work_builder prompt (#205) words the Persona handoff as
  "outside the scope of responsibility", which the work-only filter did not
  match, so work_skill.md kept a pointer to a Persona section it lacks.
  Widen the English and Chinese patterns.
- #197 made self/yourself aliases of the new owner family, so generated
  skills whose stored meta says type "self" were renamed owner-<slug> on
  install. Stored skill metadata now maps owner back to relationship.
- owner_sources.py discover no longer crashes on a malformed MCP config
  (non-dict mcpServers, non-UTF-8 TOML/YAML).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018qsZs2yPoPC21GnGkktmwp
titanwings pushed a commit that referenced this pull request Oct 13, 2026
…'s merges

- The English work_builder prompt (#205) words the Persona handoff as
  "outside the scope of responsibility", which the work-only filter did not
  match, so work_skill.md kept a pointer to a Persona section it lacks.
  Widen the English and Chinese patterns.
- #197 made self/yourself aliases of the new owner family, so generated
  skills whose stored meta says type "self" were renamed owner-<slug> on
  install. Stored skill metadata now maps owner back to relationship.
- owner_sources.py discover no longer crashes on a malformed MCP config
  (non-dict mcpServers, non-UTF-8 TOML/YAML).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018qsZs2yPoPC21GnGkktmwp
titanwings added a commit that referenced this pull request Oct 13, 2026
…'s merges (#210)

- The English work_builder prompt (#205) words the Persona handoff as
  "outside the scope of responsibility", which the work-only filter did not
  match, so work_skill.md kept a pointer to a Persona section it lacks.
  Widen the English and Chinese patterns.
- #197 made self/yourself aliases of the new owner family, so generated
  skills whose stored meta says type "self" were renamed owner-<slug> on
  install. Stored skill metadata now maps owner back to relationship.
- owner_sources.py discover no longer crashes on a malformed MCP config
  (non-dict mcpServers, non-UTF-8 TOML/YAML).


Claude-Session: https://claude.ai/code/session_018qsZs2yPoPC21GnGkktmwp

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants