Repository navigation
fix: work-only skill handoff, legacy self skills, owner discovery crash - #210
Merged
Merged
Conversation
titanwings
force-pushed
the
fix/post-merge-review
branch
2 times, most recently
from
October 13, 2026 05:37
af1a96b to
2f6064f
Compare
…'s merges - The English work_builder prompt (#205) words the Persona handoff as "outside the scope of responsibility", which the work-only filter did not match, so work_skill.md kept a pointer to a Persona section it lacks. Widen the English and Chinese patterns. - #197 made self/yourself aliases of the new owner family, so generated skills whose stored meta says type "self" were renamed owner-<slug> on install. Stored skill metadata now maps owner back to relationship. - owner_sources.py discover no longer crashes on a malformed MCP config (non-dict mcpServers, non-UTF-8 TOML/YAML). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018qsZs2yPoPC21GnGkktmwp
titanwings
force-pushed
the
fix/post-merge-review
branch
from
October 13, 2026 05:40
2f6064f to
c6f2413
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Tianyi · project thread
Summary
Fixes three regressions found in a line-by-line review of today's merges (#197, #201, #202, #204, #205, #206).
Changes
prompts/work_builder.mdnow tells the agent to write "If asked about something outside the scope of responsibility, respond the way this colleague would (see the Persona section)."skill_writer.work_only_contentonly matched the old Chinese sentence and "outside your recorded responsibilities", so every newwork_skill.mdkept a pointer to a Persona section it does not contain (the bug fix: keep work-only skills from referring to Persona #135 fixed). The English and Chinese patterns now also match the new wording and a translated variant.selfskills (feat: add owner profile for personal agent first-run setup #197 regression). feat: add owner profile for personal agent first-run setup #197 madeself/yourselfaliases of the newownerfamily. A generated skill whose storedmeta.jsonsaystype: "self"now resolved toowner, soinstall_generated_skill.pyinstalled it asowner-<slug>instead ofrelationship-<slug>. Newnormalize_skill_character()mapsownerback torelationshipfor stored skill metadata (skill_schema.resolve_character,skill_writermeta normalization). The CLI aliases (--character self→ owner profile) are unchanged.owner_sources.py discoverraised on a non-dictmcpServers/projectsin a JSON config or a non-UTF-8 Codex/Hermes config, aborting the whole scan. Those sources are now skipped.Motivation
Post-merge review requested in the project thread.
Testing
python -m pyteston dot-skill + this branch: 113 passed (3 new tests; all 3 fail on dot-skill without the tool changes)unittest discover(CI matrix): OKpython -m compileall tools/passed; ruff count on touched files unchanged (23 before and after, all pre-existing)type: selfskill installs asrelationship-legacyself; colleague/relationship/celebrity create + install for all 8 hosts;owner_profile.py save/link/unlink;owner_sources.py discoverwith malformed configsChecklist
🤖 Generated with Claude Code
https://claude.ai/code/session_018qsZs2yPoPC21GnGkktmwp
Generated by Claude Code