[CUDA] Support SM120 block-scaled GEMM fragments and odd warp atom grids - #3257
Conversation
|
👋 Hi! Thank you for contributing to the TileLang project. Please remember to run We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀 |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: tile-ai/tilelang/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: tile-ai/tilelang/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughChangesSM120 block-scaled GEMM support
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~45 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant NVFP4Test
participant SelectBlockScaledGemmInst
participant GemmMMASm120BlockScaled
participant TensorCoreIntrinEmitterSM120
NVFP4Test->>SelectBlockScaledGemmInst: request SM120 blockscaled GEMM
SelectBlockScaledGemmInst->>GemmMMASm120BlockScaled: accept fragment A and shared B
GemmMMASm120BlockScaled->>TensorCoreIntrinEmitterSM120: infer fragment and scale layouts
TensorCoreIntrinEmitterSM120->>GemmMMASm120BlockScaled: provide load layouts and fragment stride
GemmMMASm120BlockScaled->>NVFP4Test: lower and execute GEMM
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #3256.
Support fragment A and row-major scale fragments in SM120 block-scaled GEMM, and fix compact scales for odd per-warp atom grids.
Summary
8x1partition, and updated compact-scale row selection.C++ style / lint notes
docs/developer_guide/cpp_style.md.Testing