Repository navigation
test: restore the timezone-offset case for epochSecondsOf - #209
Merged
Merged
Conversation
PR #204 folded the toEpochSeconds suite into epochSecondsOf's tests and dropped the offset case. 2026-01-01T10:00:00.900+10:00 is 2026-01-01T00:00:00.900Z, which rounds down to 1_767_225_600. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WC1gJZL1bzFPvz66HKMe6H
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the timezone-offset case that PR #204 dropped when it folded the old
toEpochSecondssuite intoepochSecondsOf's tests (packages/payments/tests/internal.test.ts, the core's./internal):10:00:00.900at+10:00is2026-01-01T00:00:00.900Z.epochSecondsOfparses withDateTime.makeand takesMath.floor(toEpochMillis / 1000), so the fraction is dropped and the result is1_767_225_600. The implementation already returns this value, so it is unchanged.Verification
vp check: pass (0 errors; the warnings were already there)vp run check: pass (13/13 tasks)vp run -r test:unit: pass (all 5 packages; payments 1368/1368 tests)vp run -r build: passvp run docgen: pass (17/17 tasks)vp run test:coverage: pass, thenfallow audit --base origin/trunk: pass ("No issues in 1 changed file")Changeset
Notes
The change is one added assertion and touches no source.
Generated by Claude Code