Skip to content

scripts/checkCommits1by1.fsx: fix failure #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knocte merged 1 commit into from
Sep 30, 2026
Merged

scripts/checkCommits1by1.fsx: fix failure #384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions scripts/checkCommits1by1.fsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1802,11 +1802,6 @@ let rec CheckCiStatus
|> Seq.sortByDescending(fun run -> run.CreatedAt)
|> Seq.tryHead

let status, conclusion =
match latestRun with
| Some run -> run.Status, run.Conclusion
| None -> failwith "No push workflow run found"

// see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks#check-statuses-and-conclusions
let incompleteRunStatuses =
[
Expand All @@ -1818,7 +1813,14 @@ let rec CheckCiStatus
"pending"
]

if List.contains status incompleteRunStatuses then
let incompleteInformation, hasFailure =
match latestRun with
| Some run ->
List.contains run.Status incompleteRunStatuses,
run.Status = "completed" && run.Conclusion = "failure"
| None -> true, false

if incompleteInformation then
if timeRemaining < timeBetweenCiStatusCheckRetries then
return ()
else
Expand All @@ -1829,7 +1831,7 @@ let rec CheckCiStatus
commitHash
commitMessage
(timeRemaining - timeBetweenCiStatusCheckRetries)
elif status = "completed" && conclusion = "failure" then
elif hasFailure then
Console.WriteLine()

Console.Error.WriteLine
Expand Down
Loading