scripts/checkCommits1by1.fsx: fix failure - #384
Merged
knocte merged 1 commit intoSep 30, 2026
Merged
Conversation
Contributor
|
/pi please review this PR |
nodefect
approved these changes
Sep 30, 2026
nodefect
left a comment
nodefect
left a comment
Contributor
There was a problem hiding this comment.
Looks good. The change handles the transient empty workflow_runs response by treating it as incomplete information and reusing the existing retry path, while preserving the failure detection logic once a run is present.
I also type-checked the script with dotnet fsi --typecheck-only scripts/checkCommits1by1.fsx successfully.
Contributor
|
Looks good. Approved the PR. I also type-checked the script with: dotnet fsi --typecheck-only scripts/checkCommits1by1.fsxand it completed successfully. View action run | Model: ppq/auto | Time: 52s | Tokens: 61.9K | Cost: $0.02 | Pi SDK v0.87.1 | Action v2.29.1-unknown (unknown @ unknown) |
Contributor
|
@webwarrior-ws CI broken!!! |
When the response to request for push runs returns result with empty workflowRuns property. This happens sometimes and would cause CI failure. Instead, wait and retry the request like it is done when run status is incomplete.
webwarrior-ws
force-pushed
the
check1by1-fix-empty-workflowRuns
branch
from
September 30, 2026 09:29
404f121 to
e185845
Compare
Collaborator
Author
|
Fixed formatting. |
Collaborator
Author
|
CI is green |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the response to request for push runs returns result with empty workflowRuns property. This happens sometimes and would cause CI failure. Instead, wait and retry the request like it is done when run status is incomplete.