Repository navigation
Fix hostname extraction when URL paths, queries or fragments contain @ - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lab treated the last @ anywhere in a typed URL as userinfo, so https://github.com/path@other.example incorrectly checked other.example and encoded it in ClientHello. Isolate the authority before interpreting userinfo, preserving the bounded bare-host parser and existing DNS restrictions.
Adds 11 independent platform-URL oracle cases covering path/query/fragment, real userinfo and ports, bare-host input, and false acceptance of a different authority. Adds three browser regressions for the rendered name verdict and ClientHello bytes, starting from a failing state to avoid stale baseline passes.
Validation: all 11 new unit regressions fail on original source; repaired suite passes 68/68 across six files. npm run build and final npm run typecheck pass; git diff --check passes. Local Playwright installation failed because the Chromium download was not a valid ZIP, so browser gates require PR CI. Uploaded Git tree matches the tested local tree exactly (0008dafa7eb1abe31a7174d7e67d44de356bf213).
Fleet work: c395acb8-efef-44b9-a7bc-8a0c4b201fc1. Starting SHA 28ad747. No merge or deployment requested.