Repository navigation
[fix] bind static mounts and file responses to the host root - #24
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 8 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static roots could be selected outside the application directory, while file responses re-read the process cwd on every request. Capture the server's physical working directory once and use it for both mount authorization and file responses (STAR-92).
Static mounts now require an existing directory beneath that root, unless the host explicitly enables
allow_unsafe_file_paths. Mounts bind to a resolved directory copy, so changing cwd or retargeting the original alias cannot select a different root. Cover relative/absolute/parent/sibling paths, symlink lifecycle, every file-response entrypoint and custom error responses.Behavior changes: create directories before mounting; outside static roots require the existing host-only opt-out; relative file responses stay anchored to the server's original directory. Go 1.19 and the pinned Starlark version are unchanged. The separate networking dependency candidate remains in #23.
Validation: failing reproductions retained locally, build, race tests twice, vet, formatting, document coverage, and Go 1.19 Linux amd64 tests with networking disabled. This branch includes the CI preparation from #22; merge #22 first. No release is requested by this PR.