Repository navigation
[fix] update networking dependencies within the reviewed Go floor - #23
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the HTTP/2, IDNA and Unicode dependencies while retaining the ecosystem interpreter at
ffb3f39dd27a. These domain dependencies require Go 1.25.0, up from Go 1.19; the shared foundation libraries retain their existing floors. Production applications should use a supported patched Go compiler.Keep x/crypto v0.55.0 for Go 1.25 compatibility. Only SHA-3 is imported; SSH/OpenPGP advisories remain disclosed, and CI rejects importing those packages without another dependency review. The fixed Starlark baseline retains its parser recursion limitation and supports host-reviewed source only.
The CI restoration (#22) and file-root fix (#24) are merged. This branch incorporates both, retaining the newer shared workflow with the corrected documentation contract and current patch resolution. Its complete combined source passed local and offline Linux amd64 Go 1.25.0 builds, two race-test passes, vet, formatting and documentation checks (47/47 builtins, 16/16 configuration accessors). Exact current-master/head coverage is unchanged at 84.15%, above the existing 81% minimum. The new head passes the six operating-system/toolchain combinations, compatibility checks, CodeQL, Codacy and Codecov Patch.
The earlier Go 1.27.1 symbol scan found no reachable package/symbol findings; three x/crypto module-level advisories remain. Codacy's 46 minimum-Go findings and two unimported SSH findings were individually reviewed and reanalysis passed; these reviews do not fix the retained vulnerabilities. Scanner rules remain enabled, and the combined head passes reanalysis.
The missing Codecov Project notification is replaced by the existing CI coverage minimum and exact local base/head coverage evidence. Other required checks remain, with the floor names aligned to the approved Go 1.25 candidate. Final dependency adoption and release confirmation remain separate.
Refs STAR-88.