Repository navigation
elfutils: patch debuginfod_find_source to accept ./-relative filenames - #6259
Draft
SebastianPaucar wants to merge 1 commit into
Draft
SebastianPaucar wants to merge 1 commit into
SebastianPaucar wants to merge 1 commit into
Conversation
spackbot-triage
Bot
added
patch
SebastianPaucar
force-pushed
the
feature/elfutils-debuginfod-relative-source
branch
from
August 28, 2026 04:53
aeb4887 to
0d28d22
Compare
(plus fix ./-prefix gate check to require full ./ prefix) elfutils: fix ./-prefix gate check to require full ./ prefix (syntax)
SebastianPaucar
force-pushed
the
feature/elfutils-debuginfod-relative-source
branch
from
August 29, 2026 04:56
94e7834 to
5945d81
Compare
2 of 11 tasks
wdconinc
added a commit
to eic/eic-spack
that referenced
this pull request
Sep 10, 2026
### Briefly, what does this PR introduce? Please link to any relevant presentations or discussions. This PR moves spack/spack-packages#6259 into a place where we can merge it sooner. ### What is the urgency of this PR? - [ ] High (please describe reason below) - [x] Medium - [ ] Low ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [x] New feature (issue: elfutils debuginfod fix) - [ ] Optimization (issue #__) - [ ] Updated documentation - [ ] other: __ ### Please check if any of the following apply - [ ] This PR introduces breaking changes. Please describe changes users need to make below. - [ ] This PR changes default behavior. Please describe changes below. - [ ] AI was used in preparing this PR. Please describe usage below. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Contributor
|
This functionality was merged into the 0.196 release, https://sourceware.org/cgit/elfutils/commit/?id=bcc06ae5c80dedc02dd0422b83c1905dccdc58ec, so if possible we should reuse that patch as a URL at https://sourceware.org/cgit/elfutils/patch/?id=bcc06ae5c80dedc02dd0422b83c1905dccdc58ec. |
Contributor
|
With that upstream fix I think we should upgrade this PR to actually target a merge into spack of the upstream patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No intended to merge, this is just for EIC's containers cherry-picking. This PR patches elfutils's
debuginfodclient to accept ./-relative source filenames, produced when-ffile-prefix-mapremaps compile-time paths (spack/compiler-wrapper#19), while preserving existing behavior for absolute filenames. cc @wdconinc