Repository navigation
elfutils: patch for debuginfod to allow relative paths - #1031
Merged
Merged
Conversation
wdconinc
requested review from
SebastianPaucar
and
a lite review from Copilot
September 9, 2026 20:15
wdconinc
enabled auto-merge (squash)
September 9, 2026 20:18
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped, matches the referenced upstream patch, and only leaves a minor formatting nit in the new package override file.
Pull request overview
This PR introduces an EIC Spack overlay for elfutils to carry a debuginfod client patch (ported from spack/spack-packages#6259) that allows ./-relative DWARF source paths to be accepted and queried.
Changes:
- Adds an
elfutilspackage override that inherits from the builtin recipe and applies a conditional patch for@0.181:+debuginfod. - Adds a patch to
debuginfod-client.cto accept./-relative filenames and construct the request URL correctly by skipping the appropriate prefix.
File summaries
| File | Description |
|---|---|
| spack_repo/eic/packages/elfutils/package.py | Introduces the EIC override of the builtin elfutils package and applies the relative-path debuginfod patch for a targeted version/variant. |
| spack_repo/eic/packages/elfutils/elfutils-debuginfod-relative-source.patch | Implements the upstream debuginfod client change to allow ./-relative source paths and adjust URL escaping accordingly. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…1032) ## 🤖 Automated Style Fixes This PR applies automated style fixes for #1031. ### Changes Applied - `spack style --fix` formatting - Ensures compliance with Spack style guidelines ### Original PR - **Number**: #1031 - **Branch**: `patch-elfutils` - **Title**: elfutils: patch for debuginfod to allow relative paths ### How to Use 1. Review the changes in this PR 2. If acceptable, merge this PR instead of the original 3. Or, pull these changes into your original branch: ```bash git fetch origin style-fix-pr-1031 git merge origin/style-fix-pr-1031 ``` --- *This PR was automatically created by the [style-and-audit workflow](https://github.com/eic/eic-spack/actions/runs/34399974882).* Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
SebastianPaucar
approved these changes
Sep 9, 2026
Contributor
Author
|
Fails on macOS but that's a stretch goal in CI right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR moves spack/spack-packages#6259 into a place where we can merge it sooner.
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply