✨ feat(flow): declared Activity atoms with toLayer and plan-time call - #182
Merged
Conversation
roninjin10
force-pushed
the
plan-node-ast
branch
from
August 11, 2026 23:27
ecca8ca to
64624ac
Compare
roninjin10
force-pushed
the
flow-activity-declared
branch
2 times, most recently
from
August 11, 2026 23:30
5d11d10 to
b883814
Compare
…Error The authoring half of the plan: seven closure-free node variants (Succeed, All, Map, AndThen, FlowCall, ActivityCall, Branch) with digested deferred functions in out-of-band tables, the Planned<T> branded placeholder whose proxy throws GraphBuildError on any computation (toPrimitive, valueOf, toString, toJSON, application), and the GraphBuildError vocabulary. Docs: docs/specs/Concepts/Unified Flow Authoring.md (cherry picked from commit 64624ac)
Activity.make gains a string-first overload: a named, schema-typed atom (payload/success/error/tier/idempotencyKey) whose implementation attaches separately via .toLayer(execute) through the existing registration and activity machinery, and whose .call(payload) records an ActivityCall node for plans. The inline options form is unchanged. Docs: docs/specs/Concepts/Unified Flow Authoring.md (cherry picked from commit b883814)
roninjin10
force-pushed
the
plan-node-ast
branch
from
August 12, 2026 05:48
64624ac to
2cd29ff
Compare
roninjin10
force-pushed
the
flow-activity-declared
branch
from
August 12, 2026 05:48
b883814 to
6598a99
Compare
Contributor
Author
|
Review round 1 complete (sol + fable, independent). Findings for this PR were fixed and folded into its commit; the full ledger (15 fixes, 6 resolved-as-designed) lives in the stack's review notes. All 14 branches rebased and re-verified: whole-repo check green, all package suites at 100% coverage, rebuilt tip byte-identical to the verified fix tree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The declared (named) Activity form of
docs/specs/Concepts/Unified Flow Authoring.md— the atom half of the two-noun model:Activity.make(tag, { payload, success?, error?, tier?, idempotencyKey? })returnsActivity.Declared: schema-typed, annotatable, catalogable..toLayer(execute)attaches the implementation as a Layer through the existing flow-registration + inline-activity execution machinery (tier, idempotency,executeEncodedsemantics preserved)..call(payload)records anActivityCallnode (PR1's AST) — plan-time only, executes nothing; payload fields acceptPlannedrefs.Activity.make(options)form is byte-for-byte unchanged (overload discriminates on first-arg type).@smthrs/planas a dependency of@smthrs/flow(lockfile regenerated with--package-lock-only --ignore-scripts).Depends-on: #181
Verification
npm run check --workspace @smthrs/flow— cleannpm run lint --workspace @smthrs/flow— cleantest/ActivityDeclared.test.ts(5 tests: overload discrimination, declared fields, toLayer execution with decoded payload, call-node shape, annotations); full package suite 13 files green with the enforced 100% coverage gate