✨ feat(flow): flow body, trampoline outcome values, authoring annotations - #183
Merged
Conversation
roninjin10
force-pushed
the
flow-activity-declared
branch
from
August 11, 2026 23:27
c775445 to
5d11d10
Compare
roninjin10
force-pushed
the
flow-body-values
branch
from
August 11, 2026 23:27
1fe7197 to
009cf09
Compare
roninjin10
force-pushed
the
flow-activity-declared
branch
from
August 11, 2026 23:30
5d11d10 to
b883814
Compare
roninjin10
force-pushed
the
flow-body-values
branch
from
August 11, 2026 23:30
009cf09 to
ad7df62
Compare
…Error The authoring half of the plan: seven closure-free node variants (Succeed, All, Map, AndThen, FlowCall, ActivityCall, Branch) with digested deferred functions in out-of-band tables, the Planned<T> branded placeholder whose proxy throws GraphBuildError on any computation (toPrimitive, valueOf, toString, toJSON, application), and the GraphBuildError vocabulary. Docs: docs/specs/Concepts/Unified Flow Authoring.md (cherry picked from commit 64624ac)
Activity.make gains a string-first overload: a named, schema-typed atom (payload/success/error/tier/idempotencyKey) whose implementation attaches separately via .toLayer(execute) through the existing registration and activity machinery, and whose .call(payload) records an ActivityCall node for plans. The inline options form is unchanged. Docs: docs/specs/Concepts/Unified Flow Authoring.md (cherry picked from commit b883814)
…otations Flow.make accepts an optional plan-time body (required once the migration completes), Flow.prototype.call records a FlowCall node, the trampoline outcome vocabulary lands as pure data (Flow.done / flow.to / Flow.park over the existing Waiting reasons), and Capabilities / EffectsDeclaration / Placement join the annotation keys. Docs: docs/specs/Concepts/Unified Flow Authoring.md Docs: docs/specs/Concepts/Trampoline Loops.md (cherry picked from commit ad7df62)
roninjin10
force-pushed
the
flow-body-values
branch
from
August 12, 2026 05:48
ad7df62 to
c7865ac
Compare
roninjin10
force-pushed
the
flow-activity-declared
branch
from
August 12, 2026 05:48
b883814 to
6598a99
Compare
Contributor
Author
|
Review round 1 complete (sol + fable, independent). Findings for this PR were fixed and folded into its commit; the full ledger (15 fixes, 6 resolved-as-designed) lives in the stack's review notes. All 14 branches rebased and re-verified: whole-repo check green, all package suites at 100% coverage, rebuilt tip byte-identical to the verified fix tree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The composite half of the two-noun model (
docs/specs/Concepts/Unified Flow Authoring.md) plus the trampoline vocabulary ofTrampoline Loops.md, as pure data — engine semantics land in PR6.Flow.makeacceptsbody?: (payload) => Node— plan-time-only, typed against the decoded payload; JSDoc states it becomes required at the end of the migration (enforcement PR).flow.call(payload): Node— records aFlowCallnode, mirrors PR2's activity.call.Flow/Outcome.ts:Flow.done(value)·flow.to(payload)(schema-encodable invocation record) ·Flow.park(reason)over the existingWaitingreason vocabulary. Tagged union, schema round-trip tested.Capabilities(Reference, default[]),EffectsDeclaration,Placement— shapes consistent with@smthrs/plan'sNodeEffects.Depends-on: #182
Verification
npm run check/lint/circularfor@smthrs/flow— cleantest/FlowAuthoring.test.ts; full package suite 14 files / 121 tests, 100% coverage enforced by the run (independently re-verified)