Repository navigation
workflows: gate execution metadata behind FeatureExecutionMetadataActivePeriod - #24246
Open
prashantkumar1982 wants to merge 5 commits into
Open
prashantkumar1982 wants to merge 5 commits into
prashantkumar1982 wants to merge 5 commits into
Conversation
…ivePeriod Populate WorkflowExecutionMetadata in the ExecuteRequest (engine subscribe and trigger paths, standalone engine) only while the window covers the execution timestamp. Off by default: the field changes the request bytes that confidential workflows hash across nodes, so mixed-version DONs diverged (enclave quorum timeout, 1 of 7 signatures). Requires chainlink-common FeatureExecutionMetadataActivePeriod (#2566). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
✅ No conflicts with other open PRs targeting |
With metadata behind FeatureExecutionMetadataActivePeriod, the test enables the window on every DON node at once, so baseline and PR nodes agree and the mixed-env skips added with CRE-5839 are no longer needed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
vreff
previously approved these changes
Nov 19, 2026
jmank88
previously approved these changes
Nov 19, 2026
…ePeriod Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
prashantkumar1982
dismissed stale reviews from jmank88 and vreff
via
November 20, 2026 00:18
0888fd6
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…rom year 1 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
prashantkumar1982
marked this pull request as ready for review
November 20, 2026 01:35
product-security-plaid-production
Bot
requested review from
DylanTinianov and
kalverra
November 20, 2026 01:35
prashantkumar1982
enabled auto-merge
November 20, 2026 01:59
bolekk
approved these changes
Nov 20, 2026
| // which confidential workflows hash across nodes, so at is the execution timestamp (DON time): | ||
| // every node then switches on the same execution. An execution without a timestamp (zero time, | ||
| // when ExecutionTimestampsEnabled is off) stays off unless the window reaches back to year 1. | ||
| func (e *baseEngine) executionMetadata(ctx context.Context, at time.Time, executionID string) *sdkpb.WorkflowExecutionMetadata { |
Contributor
There was a problem hiding this comment.
nit: rename "at" -> "executionTimestamp"?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires
PerWorkflow.FeatureExecutionMetadataActivePeriod). This PR does not compile until that merges andgo.modis bumped to it, hence draft.Summary
Puts everything added in #24193 (CRE-5839) behind the new atomic feature flag
PerWorkflow.FeatureExecutionMetadataActivePeriod, off by defaultWhy
SdkExecuteRequest(now carryingExecutionMetadata) is part of the confidential-workflows capability input, which the enclave host hashes to batch requests across workflow nodes. A node with the field cannot batch with nodes without it: after upgrading one prod zone-a node to 2.74.1 its canary failed withenclave quorum timeout: received 1 of 7 required signatures within 20s(publicDataLen 591 -> 772). Mixed-version DONs diverge during a staggered rollout. With the flag off, 2.74.x builds the same request as 2.73.Enable the window only after every node in the DON runs a version that supports it. Without an execution timestamp (
ExecutionTimestampsEnabledoff) it stays off unless the window reaches back to year 1.