Skip to content

workflows: gate execution metadata behind FeatureExecutionMetadataActivePeriod - #24246

Open
prashantkumar1982 wants to merge 5 commits into
developfrom
fix/execution-metadata-active-period
Open

prashantkumar1982 wants to merge 5 commits into
developfrom
fix/execution-metadata-active-period

Conversation

@prashantkumar1982

@prashantkumar1982 prashantkumar1982 commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Requires

Summary

Puts everything added in #24193 (CRE-5839) behind the new atomic feature flag PerWorkflow.FeatureExecutionMetadataActivePeriod, off by default

Why

SdkExecuteRequest (now carrying ExecutionMetadata) is part of the confidential-workflows capability input, which the enclave host hashes to batch requests across workflow nodes. A node with the field cannot batch with nodes without it: after upgrading one prod zone-a node to 2.74.1 its canary failed with enclave quorum timeout: received 1 of 7 required signatures within 20s (publicDataLen 591 -> 772). Mixed-version DONs diverge during a staggered rollout. With the flag off, 2.74.x builds the same request as 2.73.

Enable the window only after every node in the DON runs a version that supports it. Without an execution timestamp (ExecutionTimestampsEnabled off) it stays off unless the window reaches back to year 1.

…ivePeriod

Populate WorkflowExecutionMetadata in the ExecuteRequest (engine subscribe
and trigger paths, standalone engine) only while the window covers the
execution timestamp. Off by default: the field changes the request bytes
that confidential workflows hash across nodes, so mixed-version DONs
diverged (enclave quorum timeout, 1 of 7 signatures).

Requires chainlink-common FeatureExecutionMetadataActivePeriod (#2566).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

With metadata behind FeatureExecutionMetadataActivePeriod, the test enables
the window on every DON node at once, so baseline and PR nodes agree and the
mixed-env skips added with CRE-5839 are no longer needed.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
vreff
vreff previously approved these changes Nov 19, 2026
jmank88
jmank88 previously approved these changes Nov 19, 2026
…ePeriod

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@prashantkumar1982
prashantkumar1982 dismissed stale reviews from jmank88 and vreff via 0888fd6 November 20, 2026 00:18
prashantkumar1982 and others added 2 commits November 19, 2026 16:47
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…rom year 1

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@prashantkumar1982
prashantkumar1982 marked this pull request as ready for review November 20, 2026 01:35
@prashantkumar1982
prashantkumar1982 requested review from a team as code owners November 20, 2026 01:35
@prashantkumar1982 prashantkumar1982 added the skip-mixed-env This will disable mixed-env tests in CRE. Use this when you are sure this test isn't needed for a PR label Nov 20, 2026
// which confidential workflows hash across nodes, so at is the execution timestamp (DON time):
// every node then switches on the same execution. An execution without a timestamp (zero time,
// when ExecutionTimestampsEnabled is off) stays off unless the window reaches back to year 1.
func (e *baseEngine) executionMetadata(ctx context.Context, at time.Time, executionID string) *sdkpb.WorkflowExecutionMetadata {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: rename "at" -> "executionTimestamp"?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-mixed-env This will disable mixed-env tests in CRE. Use this when you are sure this test isn't needed for a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants