Repository navigation
[2.74.2 hotfix] Gate workflow execution metadata behind FeatureExecutionMetadataActivePeriod - #24248
Draft
prashantkumar1982 wants to merge 5 commits into
Draft
prashantkumar1982 wants to merge 5 commits into
prashantkumar1982 wants to merge 5 commits into
Conversation
…ivePeriod Populate WorkflowExecutionMetadata in the ExecuteRequest (engine subscribe and trigger paths, standalone engine) only while the window covers the execution timestamp. Off by default: the field changes the request bytes that confidential workflows hash across nodes, so mixed-version DONs diverged (enclave quorum timeout, 1 of 7 signatures). Requires chainlink-common FeatureExecutionMetadataActivePeriod (#2566). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
With metadata behind FeatureExecutionMetadataActivePeriod, the test enables the window on every DON node at once, so baseline and PR nodes agree and the mixed-env skips added with CRE-5839 are no longer needed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…rom year 1 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ePeriod Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
✅ No conflicts with other open PRs targeting |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix 2.74.2: gate workflow execution metadata
Backport of #24246 onto
release/2.74.1, to ship as 2.74.2-rc.0.Problem
#24193 (in 2.74.x) added
WorkflowExecutionMetadatato every workflow'sExecuteRequestunconditionally. Confidential-workflows requests hashPublicData(which embeds that request) across nodes, so a DON mixing 2.73 and 2.74 nodes splits into batches that never reach quorum (quorum_timeout, 1 of 7 on prod zone-a, after the first node was upgraded).Fix
Execution metadata is only sent when the execution timestamp falls inside the new atomic
PerWorkflow.FeatureExecutionMetadataActivePeriodwindow (default off), so 2.74.x emits the same request as 2.73 until the window is enabled DON-wide. Applies tobase_engine.go(Subscribe and startExecution) and the standalone engine.Contents
Verification
Workflow packages build, vet and
core/services/workflows/v2+cmdtests pass locally. In #24246 CI everything is green except the confidential Relay mixed-env test, which is expected while thedevelopbaseline still sends metadata unconditionally.🤖 Generated with Claude Code