Skip to content

ConsensusQueue: wire no-op ReportingPlugin - #23901

Merged
jmank88 merged 13 commits into
developfrom
CRE-6002-consensus-queue-wiring
Nov 17, 2026
Merged

jmank88 merged 13 commits into
developfrom
CRE-6002-consensus-queue-wiring

Conversation

@jmank88

@jmank88 jmank88 commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

@jmank88
jmank88 requested review from MStreet3 and agparadiso October 5, 2026 13:13
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@jmank88
jmank88 force-pushed the CRE-6002-consensus-queue-wiring branch from 78e9b52 to e04cd2d Compare October 5, 2026 13:18
@trunk-io

trunk-io Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@jmank88
jmank88 force-pushed the CRE-6002-consensus-queue-wiring branch from e04cd2d to 1c33ed0 Compare October 5, 2026 13:33
type contractTransmitter struct {
lggr logger.Logger
fromAccount ocrtypes.Account
eventSink triggers.EventSink

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so at the very least I would expect the ability to map a workflow ID to an event sink. we chose to have just the single engine registry and this is wrapped by the coordinator. If we wire as-is, we need a TODO to come back and address this dependency

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created this ticket for this 👉🏼 https://smartcontract-it.atlassian.net/browse/CRE-7332

@cl-sonarqube-production

Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
7 New Major Issues (required ≤ 5)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE SonarQube for IDE

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

CORA - Analysis Skipped

Reason: The number of code owners (4) is less than the minimum required (5) and/or the number of CODEOWNERS entries with changed files (4) is less than the minimum required (2).

@jmank88
jmank88 force-pushed the CRE-6002-consensus-queue-wiring branch from 3d49d6a to ec7c4a4 Compare October 29, 2026 12:17
@jmank88 jmank88 changed the title add ContractTransmitter; wire Limits from job spec; write random data to KV; add validation case ConsensusQueue: wire no-op ReportingPlugin Oct 29, 2026
@jmank88
jmank88 added this pull request to stack #24103 October 29, 2026 12:20
@jmank88
jmank88 force-pushed the CRE-6002-consensus-queue-wiring branch from ec7c4a4 to 8f1afd8 Compare October 30, 2026 18:53
@agparadiso
agparadiso force-pushed the CRE-6002-consensus-queue-wiring branch 2 times, most recently from 8ee18a7 to 034798a Compare November 10, 2026 11:33
@agparadiso
agparadiso force-pushed the CRE-6002-consensus-queue-wiring branch from 034798a to 980d4c7 Compare November 10, 2026 11:56
@@ -0,0 +1,14 @@
type = "offchainreporting2"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth chatting with @bolekk / @vyzaldysanchez to see whether we can just launch this with the cap reg, and so avoid the job spec?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Obvs doesn't need to block this PR)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

registry driven launch ticket 👉🏼 https://smartcontract-it.atlassian.net/browse/CRE-7342

MStreet3
MStreet3 previously approved these changes Nov 10, 2026
return nil
}

// deployContract deploys the OCR3 contract the job spec uses as its contractID.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does a contract still needed? This is just for local CRE?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not only local CRE, the template has this contractID that needs to be filled. Its a contract because the way the ProposeJobSpec tooling works is that it resolves the contractID from filtering on contractQualifier

Its also used when building relayer.NewPluginProvider

If we move to the registry-driven launch @cedric-cordenier mentioned in the other comment this contract and jobspec go away.

}

// Vault and DKG carry their plugin config in the OCR offchain config.
// Other OCR 3.1 plugins read it from the job spec, so it stays empty here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this works -- we want the plugin config to be onchain so it's part of the config digest; this is a safety mechanism that ensures domain separation in case of diverging configs running

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, this is because we don't want to try to reach consensus with different configs (possibly different behavior) and to ensure that we use the configDigest that is carried on each consensus round and nodes ignore if they differ from the one they have, right? yeah makes sense to me. For the nop implementation its not needed I think, maybe tackling this in a separate one?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ticket to read config from config-digest protected ocr config 👉🏼 https://smartcontract-it.atlassian.net/browse/CRE-7336

The plugin produces no reports, so libocr never calls Transmit.
Event delivery will happen in the plugin's Committed step instead.
@jmank88
jmank88 added this pull request to the merge queue Nov 17, 2026
Merged via the queue into develop with commit 4cb427a Nov 17, 2026
329 of 332 checks passed
@jmank88
jmank88 deleted the CRE-6002-consensus-queue-wiring branch November 17, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants