Skip to content

pkg/capabilities/pb: expand ConsensusQueueObservation - #2495

Draft
jmank88 wants to merge 12 commits into
mainfrom
CRE-6002-consensus-queue-protos-2
Draft

jmank88 wants to merge 12 commits into
mainfrom
CRE-6002-consensus-queue-protos-2

Conversation

@jmank88

@jmank88 jmank88 commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-common

⚠️ Breaking Changes (5)

pkg/capabilities/pb (1)
  • ConsensusQueueReport — 🗑️ Removed
pkg/capabilities/pb.(*ConsensusQueueObservation) (1)
  • GetEvents — Type changed:
func(
)
- []*CoordinatedEvent
+ []*ConsensusQueueEvent
pkg/capabilities/pb.(*CoordinatedEvent) (1)
  • GetSequenceNumber — 🗑️ Removed
pkg/capabilities/pb.ConsensusQueueObservation (1)
  • Events — Type changed:
  - []*CoordinatedEvent
  + []*ConsensusQueueEvent
)
pkg/capabilities/pb.CoordinatedEvent (1)
  • SequenceNumber — 🗑️ Removed

✅ Compatible Changes (17)

pkg/capabilities/pb (8)
  • ConsensusQueueBlobHandleList — ➕ Added

  • ConsensusQueueEvent — ➕ Added

  • ConsensusQueueEventList — ➕ Added

  • ConsensusQueueObservedEvent — ➕ Added

  • ConsensusQueueObservedEventEntry — ➕ Added

  • ConsensusQueueObservedEvents — ➕ Added

  • CoordinatedEventBlobHandle — ➕ Added

  • CoordinatedEventList — ➕ Added

pkg/capabilities/pb.(*ConsensusQueueObservation) (4)
  • GetBlobHandles — ➕ Added

  • GetCapacity — ➕ Added

  • GetExpiration — ➕ Added

  • GetWorkflowCapacities — ➕ Added

pkg/capabilities/pb.ConsensusQueueObservation (4)
  • BlobHandles — ➕ Added

  • Capacity — ➕ Added

  • Expiration — ➕ Added

  • WorkflowCapacities — ➕ Added

pkg/settings/cresettings.Schema (1)
  • ConsensusQueueExpirationInterval — ➕ Added

📄 View full apidiff report

@github-actions github-actions Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 602b80b Previous: 36dfd3d Ratio
BenchmarkKeystore_Sign/hex/out-of-process 72280 ns/op 31072 ns/op 2.33

This comment was automatically generated by workflow using github-action-benchmark.

@jmank88
jmank88 force-pushed the CRE-6002-consensus-queue-protos-2 branch from 602b80b to ceedd30 Compare November 9, 2026 13:25
Comment thread pkg/capabilities/pb/triggers.proto Outdated

// ConsensusQueueObservedEvents holds a working set of observed events that are awaiting consensus.
message ConsensusQueueObservedEvents {
map<string, ConsensusQueueObservedEvent> observations = 1; // key: eventHash

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm realizing that this won't work - can't use general bytes as string keys in protos. Will need to store a list of entries instead

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant