Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metrics/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func NewRPCClientMetrics(cfg RPCClientMetricsConfig) (RPCClientMetrics, error) {
}

func (m *rpcClientMetrics) RecordRequest(ctx context.Context, rpcDomain string, isSendOnly bool, callName string, latency time.Duration, err error) {
successStr := strconv.FormatBool(err != nil)
successStr := strconv.FormatBool(err == nil)
sendStr := strconv.FormatBool(isSendOnly)
latencyNs := float64(latency)
safeRPCURL := SanitizeRPCURL(rpcDomain)
Expand Down
21 changes: 21 additions & 0 deletions metrics/client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import (
"testing"
"time"

"github.com/prometheus/client_golang/prometheus"
dto "github.com/prometheus/client_model/go"
"github.com/stretchr/testify/require"
)

Expand All @@ -28,3 +30,22 @@ func TestNoopRPCClientMetrics_RecordRequest(t *testing.T) {
m.RecordRequest(ctx, "http://localhost:8545", false, "latest_block", 100*time.Millisecond, nil)
m.RecordRequest(ctx, "http://localhost:8545", false, "latest_block", 50*time.Millisecond, errors.New("rpc error"))
}

func TestRPCClientMetrics_SuccessLabel(t *testing.T) {
m, err := NewRPCClientMetrics(RPCClientMetricsConfig{ChainFamily: "evm", ChainID: "success-label-test"})
require.NoError(t, err)

ctx := context.Background()
m.RecordRequest(ctx, "localhost:8545", false, "latest_block", time.Millisecond, nil)
m.RecordRequest(ctx, "localhost:8545", false, "latest_block", time.Millisecond, nil)
m.RecordRequest(ctx, "localhost:8545", false, "latest_block", time.Millisecond, errors.New("rpc error"))

count := func(success string) uint64 {
var pb dto.Metric
obs := RPCCallLatency.WithLabelValues("evm", "success-label-test", "localhost:8545", "false", success, "latest_block")
require.NoError(t, obs.(prometheus.Metric).Write(&pb))
return pb.GetHistogram().GetSampleCount()
}
require.Equal(t, uint64(2), count("true"), "successful calls must be success=true")
require.Equal(t, uint64(1), count("false"), "failed calls must be success=false")
}
2 changes: 1 addition & 1 deletion metrics/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ go 1.27.1

require (
github.com/prometheus/client_golang v1.23.2
github.com/prometheus/client_model v0.6.2
github.com/smartcontractkit/chainlink-common v0.11.2-0.20260923161343-170ea96c3269
github.com/stretchr/testify v1.12.1
go.opentelemetry.io/otel v1.46.0
Expand Down Expand Up @@ -31,7 +32,6 @@ require (
github.com/modern-go/reflect2 v1.0.2 // indirect
github.com/mr-tron/base58 v1.2.0 // indirect
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
github.com/prometheus/client_model v0.6.2 // indirect
github.com/prometheus/common v0.67.5 // indirect
github.com/prometheus/procfs v0.20.1 // indirect
github.com/smartcontractkit/chainlink-common/pkg/chipingress v0.0.11-0.20260915184316-2730f1867c92 // indirect
Expand Down
Loading