Repository navigation
Conversation
RecordRequest set success=FormatBool(err != nil), so success="true" meant the call failed. Docs and the deprecated chainlink-evm timing metric use success=true for successful calls. Add a regression test on the Prometheus histogram.
Contributor
📊 API Diff Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
RecordRequestsetssuccess = strconv.FormatBool(err != nil), sosuccess="true"means the call failed. The doc comment says failures usesuccess="false", and chainlink-evm's deprecatedpromEVMPoolRPCCallTiminguseserr == nil.Confirmed in prod VictoriaMetrics (10m rates):
rpc_call_latency_milliseconds_count{success="true"}= 627/s vsevm_pool_rpc_node_calls_failed_total= 605/s;success="false"= 73.4k/s vsevm_pool_rpc_node_calls_success_total= 63.4k/s.What
success=err == nil(Prometheus histogram and the Beholder OTel histogram share the value).Rollout notes
success="true"(e.g. GrafanaDON-MultiNode-RPC-Healthpanel 503 "RPC p99 call latency") currently show failed-call latency and need updating alongside the node rollout.Jira: INFOPLAT-19678 (series-reduction follow-up)