Repository navigation
fix(onboarding): improve account entry, discovery and star imports - #626
Conversation
🤖 MERGED
GitHub merged this pull request. No material findings were recorded. Another Agent took this Review. |
There was a problem hiding this comment.
Harlan Agent Kit posted this automated review. AI open source policy.
Automated Review: BLOCKED.
There was a problem hiding this comment.
Harlan Agent Kit posted this automated review. AI open source policy.
Automated Review: BLOCKED.
|
🤖 Harlan Agent Kit Agent verification of head The reported This verifies the CI finding only. The Service owns its queued Repair and Review publication. |
|
🤖 Harlan Agent Kit Agent verification of the four media findings on head All four published attachments return HTTP 200 after following GitHub's redirect. The PNGs decode and were visually inspected. The SVG also renders through the review service's existing renderer.
The attachment URLs are healthy. The Service's HTTP 400 retrieval failure remains an operational issue. Its exact failing request was unavailable, so no speculative Service change was made. |
|
🤖 Harlan Agent Kit Agent assessment of head The Service review was stopped for this exact head under the PR skill’s capacity fallback. Logged (18/100): cached proof can undercount another click after returning to the same page. Assessment confidence: 90/100. Deducted five for the broad diff and five for limited live coverage. |
|
🤖 Harlan Agent Kit browser check of head a4b466f. Adapted the NuxtSEO layout, benefit icons, hierarchy and permission footer to skilld. Checked the production build at 1440px, 768px and 375px. Both themes show the GitHub action. Phone action is 44px tall, with no horizontal overflow. Existing weekly and digest preview links open their real pages. |
|
🤖 Harlan Agent Kit Agent assessment of head The Service review stopped for this exact head under the PR skill’s capacity fallback. Logged (18/100): returning to the same login page can suppress another click count for four minutes. Assessment confidence: 90/100. Deducted five for the broad diff and five for limited live coverage. |
|
🤖 Harlan Agent Kit browser check of head 02c451c. Sign-up and sign-in use the requested headings and NuxtSEO switch transitions. Sign-up reveals the compact benefits panel; sign-in collapses it. The permission divider spans the card, both preview links are removed, and the logo is 144px wide. Checked the built Worker at 1440px and 375px. The switch and browser Back retain Like intent and the OAuth retry error. |
|
🤖 Harlan Agent Kit Agent assessment of head The Service review stopped for this exact head under the PR skill’s capacity fallback. Logged (18/100): returning to the same login page can suppress another click count for four minutes. Assessment confidence: 90/100. Deducted five for the broad diff and five for limited live coverage. |
|
🤖 Harlan Agent Kit Agent assessment of head 9101576. The exact-head Service review was stopped because ten review or repair tasks exceeded three free host slots. One independent agent reviewed the complete diff, surrounding boundaries, architecture evidence, and final original-resolution screenshots. No confirmed finding exceeds 80/100. Confidence: 90/100. Repeat anonymous click counts can be undercounted after returning within four minutes, Logged 18/100. Authentication remains usable. All applicable CI checks passed for this head. Desktop and phone UI checks passed in both themes. Live OAuth completion, production migrations, and live GitHub import latency were not exercised by this assessment. This is an independent assessment, separate from Service READY. |











🔗 Linked issue
Implements the account and onboarding UX audit and its confirmed review findings.
❓ Type of change
📚 Description
Sign-in hid the account benefits, selected likes could disappear, and star imports missed Repositories without “skill” in their names.
Show concrete account benefits and preserve Like intent through sign-in and retry.
Use NuxtSEO’s two-panel login layout with skilld branding.
Place the GitHub action before the benefits on phones.
Use explicit Sign In with GitHub and Sign Up with GitHub headings.
Switch views without losing Like or Watch intent.
Sign-up reveals compact account benefits with NuxtSEO’s panel and content transitions.
Sign-in collapses the benefits into a focused account entry.
Adapt NuxtSEO’s icon-led benefits, type hierarchy, and permission footer.
Use skilld’s editorial atmosphere, a larger logo, and a full-width permission divider.
Collapse recording prompts and expose Run controls on phones.
Guide accounts with watches and no likes toward discovery and Repository coverage.
Stage up to 1,000 GitHub stars before replacing an import, preserve previous coverage after failures, and label partial imports.
Reject malformed GitHub responses with the existing retry message.
Browser imports carry a generation identifier on every continuation.
Each public API request completes its bounded import on the server and returns
nextPage: null.The response fields stay unchanged, and the released CLI stops its import loop after that response.
A delayed legacy continuation also creates its own complete import, so it cannot mix another request’s pages.
Each GitHub page uses one staged SQL insert to stay within the Worker request budget.
Count browser sign-in clicks separately from server OAuth requests.
Click reporting requires a five-minute, single-use proof bound to the page and client.
Preparation and event intake use the existing guest rate limiter.
The browser requests proof only where a sign-in link exists. Reporting failures never block sign-in.
These limited events still do not prove a human conversion.
📝 Migration
The production workflow applies
0154_user_starred_import.sqland0155_signup_click_proofs.sqlbefore deployment.For another environment, run
pnpm exec wrangler d1 migrations apply DB --remote --config wrangler.jsoncbefore deploying this Worker.The migrations add import staging and expiring click-proof tables.
They cannot recover an import overwritten by earlier code.