Skip to content

fix(ui): improve onboarding and unify owner avatars - #627

Merged
harlan-zw merged 4 commits into
mainfrom
fix/onboarding-accessibility
Oct 12, 2026
Merged

harlan-zw merged 4 commits into
mainfrom
fix/onboarding-accessibility

Conversation

@harlan-zw

@harlan-zw harlan-zw commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

Follow-up to #626.

❓ Type of change

  • 📖 Documentation
  • 🐞 Bug fix
  • 👌 Enhancement
  • ✨ New feature
  • 🧹 Chore
  • ⚠️ Breaking change

📚 Description

Repository settings hid the main Watch action on phones and ignored saved indexing choices. Repository rows also lacked the owner avatars shown on Skill cards.

Watch now comes before settings. Saved choices have loading, retry, and save failure messages. Skill cards and Repository rows share one avatar component, with initials if an image fails.

Import updates announce to screen readers, the active step has a semantic label, and Watch removal says “Stop watching”.

Repository rows and Skill cards share an avatar; saved settings update the account cache after confirmed saves.

🤖 AI disclosure: Harlan Agent Kit modified this description. My AI open-source policy.

@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 12, 2026
@harlan-github-agent harlan-github-agent Bot added harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. and removed harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. labels Oct 12, 2026
@harlan-zw

Copy link
Copy Markdown
Collaborator Author

🤖 Harlan Agent Kit Agent browser assessment of head 90d4650ed7717d5ccf24ad1ae627fdf5f1e136e4.

Real production walkthrough used the Agent GitHub account harlan-agent-beep. OAuth, a one-match star import, Watch creation (inserted:1), and reload persistence passed. Temporary test data was removed. Existing Likes, Watches, and email choices were preserved.

The built local app used controlled account responses for the new UI states. At375×812, Watch1 occupies y620–664, above repository settings. Turning indexing off, leaving for Email, and returning preserved the off state. A separate agent reviewed the source and full-resolution phone and desktop screenshots without finding a material defect.

Before, production After, local controlled account
Notice pushes primary action below the phone viewport Watch appears before repository settings

Saved indexing-off state after remount, desktop

Limits: brand-new OAuth account creation, full1,000-star import, assistive-device playback, and actual email delivery were not exercised.

@harlan-github-agent

harlan-github-agent Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

🤖 MERGED

Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy. Last updated: 2026-10-12 06:58 UTC.

GitHub merged this pull request.

No material findings were recorded.

Another Agent took this Review.

@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. label Oct 12, 2026
@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 12, 2026
@harlan-github-agent harlan-github-agent Bot added harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. and removed harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. labels Oct 12, 2026
@harlan-zw harlan-zw changed the title fix(identity): improve onboarding actions and saved settings fix(ui): improve onboarding and unify owner avatars Oct 12, 2026
@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 12, 2026
@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 12, 2026
@harlan-zw

Copy link
Copy Markdown
Collaborator Author

🤖 Harlan Agent Kit Agent assessment of head 3817566729422de7749c9f95b1405429aea86b82.

Independent review found no credible defect. GitHub Actions passed on this exact head. The service review remains stopped for this head: six Review or Repair tasks were queued, with one free host slot. This is a separate agent assessment, not a Service READY outcome.

The shared owner avatar now appears in generic Skill cards, onboarding selections, and watched Repository rows. Actual proxy images loaded in the built app. Phone names wrap cleanly, and Watch occupies y640–684 within the812pxviewport. Saved indexing-off state survives leaving for Email and returning.

Onboarding, phone Watched Repositories, phone
Onboarding shows the owner avatar beside the selected Repository Watched Repository uses the same owner avatar and clear Stop watching action

Desktop onboarding with shared owner avatar

The prior production replay proved real Agent OAuth, one-star import, Watch creation, reload persistence, and test-data cleanup. These updated UI screenshots use a controlled local account fixture. No user-facing code changed after capture; the final commit adds accessibility coverage.

Confidence95/100 for these fixes. Fresh-account creation, assistive-device playback, full1,000-star import, and actual email delivery remain untested.

@harlan-zw
harlan-zw merged commit 3b8865d into main Oct 12, 2026
7 checks passed
@harlan-zw
harlan-zw deleted the fix/onboarding-accessibility branch October 12, 2026 06:49
@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. label Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant