Skip to content

fix(signer): typecheck the signer with the site #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harlan-zw merged 1 commit into from
Oct 7, 2026
Merged

fix(signer): typecheck the signer with the site #557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"postinstall": "nuxt prepare",
"lint": "eslint .",
"lint:fix": "eslint . --fix",
"typecheck": "wrangler types --check --config wrangler.jsonc --env-file .dev.vars.example && nuxt typecheck",
"typecheck": "wrangler types --check --config wrangler.jsonc --env-file .dev.vars.example && nuxt typecheck && pnpm --filter @skilld/artifact-signer-worker typecheck",
"test": "vitest",
"test:run": "vitest run",
"test:e2e": "pnpm build:test && playwright test",
Expand Down
2 changes: 1 addition & 1 deletion shared/server/github-app-credential.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ async function readBoundedJson(response: Response, maximumBytes: number): Promis
bytes.set(chunk, offset)
offset += chunk.byteLength
}
const text = new TextDecoder('utf-8', { fatal: true }).decode(bytes)
const text = new TextDecoder('utf-8', { fatal: true, ignoreBOM: false }).decode(bytes)
// A JSON.parse error quotes the start of the body, which holds the token.
try {
return JSON.parse(text) as unknown
Expand Down
Loading