Repository navigation
fix(signer): typecheck the signer with the site - #557
Merged
Merged
Conversation
The signer imports shared/server code, but no CI job typechecked it, so a shared change broke it on main unnoticed. Workers types require ignoreBOM in TextDecoder options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Found while preparing #556.
❓ Type of change
📚 Description
The artifact signer Worker imports
shared/servercode, but no CI job typechecked it.mainfails the signer'stsc. #525 and #540 callnew TextDecoder('utf-8', { fatal: true })inshared/server/github-app-credential.ts, and the Workers types requireignoreBOMas well. The other decoders the signer reaches already passignoreBOM: false.The root
typecheckscript now also runs the signer's typecheck, so thesiteCI job covers it. Without the one-line fix, the extended script fails.