Repository navigation
feat(demos): show each demo's picture in its social card - #537
Merged
Merged
Conversation
A shared demo page unfurled into a text card, so a link to a film or a landing page showed only words. The card now shows the film's poster frame or the page's first screen, under a band with the lockup, the Skill name and the recording line. A prebuilt og:image URL cannot replace the site default card from app.vue: the generated card's meta carries tagPriority 35, which beats every unhead alias. A takumi card goes through the same payload as the default, so it replaces it.
harlan-zw
added
the
harlan-agent-review
Collaborator
Author
|
Agent check, by hand, since CI cannot render OG images (
|
harlan-github-agent
Bot
added
harlan-agent-review-required
1 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
None.
❓ Type of change
📚 Description
A shared demo page unfurled into the generic text card, so a link to a film or a landing page showed only words. Each demo page now shares a card that shows what the Agent made: the film's poster frame or the page's first screen. A band above the picture carries the lockup, "What /{name} made" and the recording line.
/skills/demoskeeps its text card.demoSocialPictureinapp/utils/home-demos.tspicks the picture. A tall page uses its first-screen poster, because a full shot runs to 6000px. A demo with neither a film poster nor a one-screen desktop picture keeps the text card.OgImage/Demo.takumi.vuedraws the card. The picture fills a window from its top edge, so a page shows its header and hero. A long Skill name shrinks to stay on one line.HomeDemoShotdeclares theposterfield that/api/skill-demosalready sends.DESIGN.mdlists the Demo card and whyOgLayoutdoes not frame it.The page cannot point
og:imageat the media URL directly.app.vuedefines a default card for every page, and nuxt-og-image gives that card's metatagPriority: 35. Unhead ranks 35 above every priority alias, so a prebuilturlnever replaces the default card. A takumi card replaces it through the same payload key.