Repository navigation
feat(demos): show the demo picture in a Skill page's social card - #543
Merged
Merged
Conversation
A shared Skill page with a demo showed the plain Skill card, while its demo page showed what the Agent made. A Skill page only demo has no demo page, so its Skill page link is the only one to share.
Collaborator
Author
|
Agent check, run by hand because CI cannot render a social card:
|
harlan-zw
added
the
harlan-agent-review
harlan-github-agent
Bot
added
harlan-agent-review-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
No linked issue.
❓ Type of change
📚 Description
A shared Skill page showed the plain Skill card, even when the Skill had a demo. Demo pages already show what the Agent made (#537). A Skill page only demo, such as shipreel's (#536), has no demo page, so its Skill page is the only link to share.
A Skill page with a demo now uses the
Demo.takumicard: "What /{name} made", how the demo was recorded, and the film's poster frame or the page's first screen. A Skill without a demo, or with a demo that has no such picture, keeps theSkill.takumicard.demoSocialPicturenow takes only thevideoandshotsit reads, so the Skill page can pass its own demo view.