Repository navigation
feat(demos): add a shipreel demo shown on its Skill page only - #536
Merged
Merged
Conversation
Some demos suit their Skill page but not the /skills/demos board, the homepage, or a demo page of their own. A skillPageOnly entry keeps the demo on its Skill page alone, and the recorder sets it with --skill-page-only.
harlan-zw
added
the
harlan-agent-review
harlan-github-agent
Bot
added
harlan-agent-review-required
…only # Conflicts: # scripts/record-skill-demo.ts
harlan-zw
added
the
harlan-agent-review
harlan-github-agent
Bot
removed
the
harlan-agent-review
1 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
No linked issue.
❓ Type of change
📚 Description
Some demos should show on their Skill page and nowhere else. Until now every demo also landed on the
/skills/demosboard, the homepage section, its own demo page, and thedemossitemap. Thethebstar/shipreeldemo is the first one kept to its Skill page.Skill page only demos
skillPageOnly: truestays out oflistShownSkillDemos. The board, the homepage, and the sitemap leave it out, and its demo page answers 404. It does not count toward the six demos the board needs to be indexable.pinon such a demo, because a pin orders the homepage.pnpm demo:record ... --skill-page-onlysets the flag. A re-record keeps it.GLOSSARY.md(demo placement) andCOPY.md(Demo panel) describe it.The shipreel demo
shipreel turns a pull request into a narrated walkthrough video. The seed folder held Mossgrove, a small fictional booking API, with an idempotency-key change on a branch. shipreel defaults to macOS
say, so the seed'sshipreel.ymlnames a local Piper voice and a 60 second target. The demo'ssetupline says so.The Agent made a 63 second film in four chapters, with narration, captions, diagrams, and code panels. The 720p web copy is 1.4 MB on
media.skilld.dev.