Skip to content

fix(header): link the skilld CLI repository, drop the sign-in icon #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harlan-zw merged 1 commit into from
Oct 6, 2026
Merged

fix(header): link the skilld CLI repository, drop the sign-in icon #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions app/app.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,16 @@ watch(() => route.fullPath, () => {
<div class="flex items-center justify-end gap-1.5 lg:flex-1">
<SkillSearchTrigger v-if="$route.path !== '/'" />
<HeaderNavigation />
<UButton

@harlan-github-agent harlan-github-agent Bot Oct 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open (85/100): Header and footer GitHub icons link to the private site repository, giving every visitor a GitHub 404, while the PR's own accessibility fix uses the public CLI repository for exactly this reason.

Proof: skilld-dev/skilld.dev is private (anonymous GitHub resolve fails), while skilld-dev/skilld is public. The new header UButton, the footer UButton (app/app.vue:295), and the accessibility link correctly use the CLI repo, but the header and fo.

Next: Point the header and footer GitHub buttons at https://github.com/skilld-dev/skilld, matching the accessibility page link and the PR's stated rationale.

Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy.

to="https://github.com/skilld-dev/skilld"
target="_blank"
icon="i-lucide-github"
aria-label="skilld CLI on GitHub (opens in new tab)"
color="neutral"
variant="ghost"
size="sm"
class="min-h-11 min-w-11"
/>
<UColorModeButton
color="neutral"
variant="ghost"
Expand Down Expand Up @@ -282,10 +292,10 @@ watch(() => route.fullPath, () => {
@click="() => { shortcutsModalOpen = true }"
/>
<UButton
to="https://github.com/harlan-zw/skilld"
to="https://github.com/skilld-dev/skilld"
target="_blank"
icon="i-lucide-github"
aria-label="GitHub repository (opens in new tab)"
aria-label="skilld CLI on GitHub (opens in new tab)"
color="neutral"
variant="ghost"
size="xs"
Expand Down
2 changes: 0 additions & 2 deletions layers/identity/app/components/HeaderAccount.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ const accountItems = computed<DropdownMenuItem[]>(() => {
v-else-if="state._tag === 'anonymous'"
:to="signInTo"
label="Sign in"
icon="i-lucide-github"
color="neutral"
variant="ghost"
size="sm"
Expand Down Expand Up @@ -94,7 +93,6 @@ const accountItems = computed<DropdownMenuItem[]>(() => {
v-else-if="state._tag === 'anonymous'"
:to="signInTo"
label="Sign in"
icon="i-lucide-github"
color="neutral"
variant="ghost"
block
Expand Down
2 changes: 1 addition & 1 deletion layers/marketing/app/pages/accessibility.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ defineOgImage('Page.takumi', {
<p class="text-sm text-muted leading-relaxed">
Found an accessibility barrier? Please
<a
href="https://github.com/harlan-zw/skilld/issues"
href="https://github.com/skilld-dev/skilld/issues"
target="_blank"
rel="noopener noreferrer"
class="text-default underline underline-offset-2 hover:text-[var(--color-primary-500)]"
Expand Down