Repository navigation
fix(header): link the skilld CLI repository, drop the sign-in icon - #482
Conversation
The GitHub icon sat on "Sign in", so the header had no real GitHub link. The footer and accessibility links used the old harlan-zw/skilld path, which only reaches the CLI through a redirect.
harlan-zw
added
the
harlan-agent-review
|
Agent comment. Checked by hand, since CI cannot cover it:
|
harlan-github-agent
Bot
added
harlan-agent-review-required
🤖 MERGED
GitHub merged this pull request.
A fresh Review found no repairable finding. Selected findings run after merge and open separate pull requests. |
harlan-zw
added
the
harlan-agent-review-required
harlan-github-agent
Bot
added
harlan-agent-blocked
![harlan-github-agent[bot]](https://avatars.githubusercontent.com/in/4579275?s=60&v=4){kind=small}
| <div class="flex items-center justify-end gap-1.5 lg:flex-1"> | ||
| <SkillSearchTrigger v-if="$route.path !== '/'" /> | ||
| <HeaderNavigation /> | ||
| <UButton |
There was a problem hiding this comment.
Open (85/100): Header and footer GitHub icons link to the private site repository, giving every visitor a GitHub 404, while the PR's own accessibility fix uses the public CLI repository for exactly this reason.
Proof: skilld-dev/skilld.dev is private (anonymous GitHub resolve fails), while skilld-dev/skilld is public. The new header UButton, the footer UButton (app/app.vue:295), and the accessibility link correctly use the CLI repo, but the header and fo.
Next: Point the header and footer GitHub buttons at https://github.com/skilld-dev/skilld, matching the accessibility page link and the PR's stated rationale.
Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy.
There was a problem hiding this comment.
Harlan Agent Kit posted this automated review. AI open source policy.
Automated Review: BLOCKED.
harlan-github-agent
Bot
added
harlan-agent-running
|
Agent comment. Header after this change, captured in headless Chrome: Desktop, 1440px
Mobile, 390px
Mobile, menu open
|
harlan-github-agent
Bot
removed
the
harlan-agent-running
harlan-github-agent
Bot
added
harlan-agent-running
1 participant
🔗 Linked issue
None.
❓ Type of change
📚 Description
The header had no GitHub link. The "Sign in" button carried the GitHub icon, so it read as one. The footer and the accessibility page linked to the old
harlan-zw/skilldpath, which reaches the CLI only through a GitHub redirect.The header now shows a GitHub icon that opens
skilld-dev/skilld. "Sign in" shows its label only. The footer link and the accessibility feedback link also point atskilld-dev/skilld. The feedback link uses the CLI repository because the site repository is private.