Skip to content

fix(trending): compact spark and people-first quotes - #473

Merged
harlan-zw merged 3 commits into
mainfrom
fix/trending-board-polish
Oct 6, 2026
Merged

harlan-zw merged 3 commits into
mainfrom
fix/trending-board-polish

Conversation

@harlan-zw

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

None. Harlan asked for these changes directly.

❓ Type of change

  • 📖 Documentation
  • 🐞 Bug fix
  • 👌 Enhancement
  • ✨ New feature
  • 🧹 Chore
  • ⚠️ Breaking change

📚 Description

On a wide screen, the trending board left a large gap between a short Skill name and its words. The name column took a share of the row, so it grew with the screen. Bot accounts such as @grok and github-trending.bsky.social led the quote line on two rows of this month's board, and their emoji and Unicode bold were the loudest text in those rows.

  • The row's name column stops at 17rem and truncates the name. The words take the rest.
  • The new SparkDots draws the spark and the trending mark as SVG columns of dots. In headless Chrome on Linux, the spark beside each name went from 70px to 20px, and the header mark from 42px to 11px. Plain text, such as the weekly email, keeps the braille bars.
  • The quote line sits one size under the description, with a muted handle. Only the Skill name in it lifts to toned ink. Post text and poster names drop emoji, and NFKC folds Unicode letter styles back to plain letters.
  • loadSocialEvidence quotes a person before an automated account, and lists people first among the other posts. shared/automated-authors.ts holds the accounts found in production posts. Ranking still counts every author.
  • The homepage shows the top five board rows, up from three.

Architecture of the change: the loader picks a person's post first, the shared text helper strips emoji and letter styles, and the row components draw the fixed name column and the dot spark

🤖 AI disclosure: Harlan Agent Kit modified this description. My AI open-source policy.

harlan-zw and others added 2 commits October 6, 2026 23:47
The trending board left a wide gap between short Skill names and their
words, because the name column grew with the screen. The braille spark
ran about 60px per row in a fallback font. Bot accounts led the quote
line, and their emoji and Unicode bold were the loudest text in a row.

Co-Authored-By: Claude <noreply@anthropic.com>
@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 6, 2026
@harlan-zw

Copy link
Copy Markdown
Collaborator Author

Agent comment. Checked in a local dev server reading production data through a scratch proxy, since CI cannot show layout:

  • At 1440px the name column is 272px and the words start right after it. At 1920px the extra width goes to the words.
  • At 390px the rows stack and the page has no sideways scroll.
  • Emoji and Unicode bold are gone from the quote lines. The homepage shows five rows.
  • The proxy serves production's feed, so these shots still show github-trending.bsky.social and @grok leading two rows. The people-first order runs in the server loader and is covered by the new unit tests.
Before, 1440px After, 1440px
Before After
Homepage, five rows Phone, 390px
Homepage Phone

@harlan-github-agent harlan-github-agent Bot added harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. and removed harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. labels Oct 6, 2026
@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 6, 2026
@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 6, 2026
@harlan-github-agent

harlan-github-agent Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

🤖 MERGED

Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy. Last updated: 2026-10-06 15:09 UTC.

GitHub merged this pull request.

  • Logged (30/100): The PR's visual evidence is inaccessible, so the visible-UI claims in the description and comment are unverified by screenshot. View code
    • Ask an agent to verify and fix this finding

Review completed. No finding above 80/100.

Selected findings run after merge and open separate pull requests.

@harlan-zw
harlan-zw merged commit 833f7f4 into main Oct 6, 2026
7 checks passed
@harlan-zw
harlan-zw deleted the fix/trending-board-polish branch October 6, 2026 13:22
@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. label Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant