Repository navigation
fix(trending): strip post emoji on the server only - #474
Merged
Merged
Conversation
Production boards failed hydration after #473. The excerpt helper stripped emoji on both sides, and Node 24 and Chrome 145 disagree about which characters are emoji (`★`), so the server and the browser rendered different quote text. The loader now strips once, and the page renders the text it receives.
harlan-zw
added
the
harlan-agent-review
harlan-github-agent
Bot
added
harlan-agent-review-required
Contributor
🤖 MERGED
GitHub merged this pull request.
59c69f7f-85f2-4c65-85c6-5e03caf79c30 Selected findings run after merge and open separate pull requests. |
harlan-github-agent
Bot
added
harlan-agent-ready
![harlan-github-agent[bot]](https://avatars.githubusercontent.com/in/4579275?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Harlan Agent Kit posted this automated review. AI open source policy.
Automated Review: READY.
harlan-github-agent
Bot
removed
the
harlan-agent-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related to #473.
❓ Type of change
📚 Description
After #473 deployed,
/skills/trendingand the homepage logged "Hydration completed but contains mismatches". The shared excerpt helper stripped emoji with\p{Extended_Pictographic}on the server and again in the browser. The two engines disagree about some characters: Node 24 does not count★as an emoji, and Chrome 145 does. So the server rendered33.5k★and the browser rendered33.5k.The loader's
toEvidencenow strips emoji and folds letter styles once, on the server. The feed and the track board ship plain text, andpostExcerptno longer uses Unicode property escapes or normalization. Both engines now cut the same text.