Repository navigation
feat(skillgen): support monorepo packages and polish the opt-in page - #462
Merged
Merged
Conversation
Harlan's account page refused most of his repositories. They are monorepos: the root package.json is private or names the monorepo, and the published package keeps its Skill under packages/<name>/skills/. One rule in workers/skill-harness/src/package-skills.ts now finds every package with a Skill at the root or under packages/, and the site imports the same rule. A tag that several packages share splits into one job per package, each with its own branch and draft, since nuxt-seo releases two packages with Skills at once. The account page checks every repository when it loads, so a blocked one shows its reason before any click. Ready rows name the packages Skillgen updates, and "Turn on all" switches on every ready repository. useFetch data is shallow in Nuxt 4, so rows now update by replacing the list.
harlan-zw
added
the
harlan-agent-review
Collaborator
Author
|
An agent wrote this comment. Checked by hand in a headless browser against
|
harlan-github-agent
Bot
added
harlan-agent-review-required
Contributor
🤖 MERGED
GitHub merged this pull request.
Review completed. No finding above 80/100. Selected findings run after merge and open separate pull requests. |
harlan-github-agent
Bot
added
harlan-agent-running
1 of 6 tasks
harlan-github-agent
Bot
removed
the
harlan-agent-review-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related to #450
❓ Type of change
📚 Description
Harlan's Skillgen account page refused most of his repositories. They are monorepos: the root
package.jsonis private or names the monorepo, and the published package keeps its Skill underpackages/<name>/skills/. He also asked for a cleaner page and a way to turn every repository on at once.workers/skill-harness/src/package-skills.tsfinds every package with a Skill. A package sits at the root or underpackages/<name>/, has a public namedpackage.json, and keeps its Skill inskills/<dir>/SKILL.mdbeside it. The Worker uses the rule to prepare a tag, and the account page imports it to check eligibility. Skills deeper in a package, such as test fixtures, are ignored.1.2.3,v1.2.3orname@1.2.3. If one tag matches several packages, the job splits into one job per package. Each gets its own branch,skilld/<sha>-<package dir>, and a title that names the package.nuxt-seoreleases@nuxtjs/seoandnuxtseo-layer-devtoolstogether, so it needs the split.useFetchdata is shallow in Nuxt 4; before this, a saved switch did not re-render its row.SKILL.mdat the root./skillgen,COPY.mdand the runbook describe the new layout.📝 Migration
After merging, run the "Deploy to Cloudflare" workflow with
target=harness-proof. The site deploy changes the account page on its own, but the live Worker reads only the rootpackage.jsonuntil then.