Repository navigation
chore(deploy): deploy the Harness Worker when a merge changes it - #465
Merged
Merged
Conversation
The skilld-harness-proof Worker deployed only by hand, so merged Skillgen changes sat undeployed until someone dispatched the workflow. After a main push passes Test and the site deploys, the workflow now deploys the Worker when the merge changed it, its dependencies, or the deploy workflow. Unchanged merges skip it, because a new version restarts containers and a Skillgen job may be running in one.
harlan-zw
added
the
harlan-agent-review
harlan-github-agent
Bot
added
harlan-agent-review-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related to #462
❓ Type of change
📚 Description
The
skilld-harness-proofWorker deployed only by hand. Each Skillgen change shipped the site on merge, but the Worker kept its old version until someone ran the workflow withtarget=harness-proof. #462 is waiting on that now.After a main push passes Test and the site deploys, the
harness-proofjob now deploys the Worker when the merged commit changedworkers/skill-harness/,pnpm-workspace.yaml,pnpm-lock.yaml, or this workflow. It runs after the site, because the Worker calls site routes that the same merge may add. Merges that change none of those skip the deploy, because a new version restarts containers and a Skillgen job may be running in one. Dispatching withtarget=harness-proofstill deploys by hand.This PR changes the workflow, so its own merge deploys the Worker and ships #462.