Repository navigation
feat(og): redraw OG cards as the homepage hero - #454
Merged
Merged
Conversation
The cards still set titles in mono with the old tagline, so a shared link looked like the site before its rebrand. Every card now centres the lockup, a Plus Jakarta Sans title and its detail, with braille names in the margins, matching the new hero. The frame lives in OgLayout, so Splash and Make a skill became plain Page cards and the per-card file minimap went with them. Two-line text breaks evenly in OgLines, because takumi's text-wrap: balance shifts balanced lines off centre.
harlan-zw
added
the
harlan-agent-review
Collaborator
Author
|
🤖 Agent check of the new cards. They come from the real renderer in a local
Edge cases, after only:
|
harlan-github-agent
Bot
added
harlan-agent-review-required
Contributor
🤖 MERGED
GitHub merged this pull request. No material findings were recorded. The pull request closed. |
harlan-github-agent
Bot
removed
harlan-agent-running
The component coverage check failed because OgLines renders only inside OG images, like OgBrand and OgLayout, so no axe test mounts it.
harlan-zw
added
the
harlan-agent-review
harlan-github-agent
Bot
added
harlan-agent-review-required
harlan-zw
added
the
harlan-agent-review
1 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
None.
❓ Type of change
📚 Description
Shared links still showed the old OG cards, with mono titles and the "Curated agent skills by humans" tagline. They no longer matched the homepage hero. Every card now repeats that hero as one still frame.
OgLayoutdraws the shared frame: the lockup centred at the top, the content centred under it, and Braille names in the margins. The lockup's dot stays the card's one rose element.OgLinesbreaks two-line text into two lines of even length. The renderer'stext-wrap: balancepushes balanced lines off centre, so the card splits them itself.DESIGN.mdrecords the frame as a decision and replaces the per-card texture table.COPY.mdmoves the homepage card from the tagline to the Home H1.