Repository navigation
fix(og): keep body line breaks from breaking OG cards - #456
Merged
Merged
Conversation
A bio, note or collection description with its own line breaks lost everything past its second line, or drew an empty row, because the explicit break meant for the homepage title applied to body text too. Only titles honour a break now; body text collapses to one paragraph. The docs claimed the margin field resolves toward the lockup's dot, which the clear column prevents, so they now describe what the card shows. The Home H1 row names its OG alt placement again, so the copy contract checks the homepage card.
harlan-zw
added
the
harlan-agent-review
harlan-github-agent
Bot
added
harlan-agent-review-required
Contributor
🤖 MERGED
GitHub merged this pull request. No material findings were recorded. 552fb18f-0fe0-4432-b6ef-dec2a00d16c3 |
harlan-github-agent
Bot
added
harlan-agent-ready
![harlan-github-agent[bot]](https://avatars.githubusercontent.com/in/4579275?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Harlan Agent Kit posted this automated review. AI open source policy.
Automated Review: READY.
harlan-github-agent
Bot
removed
the
harlan-agent-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related to #454
❓ Type of change
📚 Description
#454 merged before this fix reached its branch.
ogEvenLineshonoured a line break in any text, but only the homepage title should. Collection descriptions, GitHub bios and curator notes arrive with breaks of their own. The OG card dropped everything past the second line, drew an empty row for a blank line, or kept a stray\r.OgLayoutandDESIGN.mddescribed the margin field as resolving toward the lockup's dot. The clear column prevents that, so they now describe a sparse dusting.COPY.mdnamesindex OG image altagain, so the copy contract checks the homepage card's alt text.