Skip to content

feat(trending): use the /skills shell with a range sidebar - #433

Merged
harlan-zw merged 2 commits into
mainfrom
feat/trending-full-width
Oct 5, 2026
Merged

harlan-zw merged 2 commits into
mainfrom
feat/trending-full-width

Conversation

@harlan-zw

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

Related to #431

❓ Type of change

  • 📖 Documentation
  • 🐞 Bug fix
  • 👌 Enhancement
  • ✨ New feature
  • 🧹 Chore
  • ⚠️ Breaking change

📚 Description

Harlan asked for /skills/trending to run full width like /skills, with a left sidebar to switch between week and month and no right-hand aside. The page now uses the /skills shell. The heading lines up with the results column, a sticky 14rem sidebar sits on the left, and the board takes the rest of the width.

  • The sidebar lists Week, Month, and All time as links to their existing URLs. Each link carries a short hint, such as Last 7 days, and the current one carries aria-current. Narrow screens show the same links as a compact row above the board.
  • On wide screens the weekly CTA and the Teach your agent skilld install sit under the range links. Narrow screens keep the CTA after the fifth row and the install under the heading. The sidebar install reports copies as trending-sidebar; the narrow one keeps trending-header.
  • TrendingWeeklyCta drops its unused row layout. In a container narrower than 16rem it tightens its copy, so the sidebar button keeps its whole label.
  • TrendingBoardItem switches on its own width with a container query. Posts sit beside the Skill once the row is 52rem wide, and the posts column grows with the board. Descriptions cap at 75ch, so rows with no posts stay readable at full width.
  • TrendingPostCarousel shows two posts at a time once it is 36rem wide. When exactly two posts fit side by side, the step controls hide.
  • "Earlier on this board" and the all-time eligibility block move into the results column. The earlier list holds Skills that have left the ranking, so the sidebar does not replace it. It is also the crawl path to every Skill the trending sitemap lists.
  • DESIGN.md gains a 2026-10-06 decision. It supersedes the 2026-10-01 call that dropped the 9/3 sidebar.

Page question: what are devs talking about this week or month? Primary action: copy the run command. Owning concern: Loop 1.

🤖 AI disclosure: Harlan Agent Kit modified this description. My AI open-source policy.

Harlan asked for the trending board to run full width like /skills, with
the week, month, and all time switch in a left sidebar and no right aside.

The sidebar carries the range links, the weekly CTA, and the skilld
install on wide screens. Narrow screens keep the range row above the
board and the CTA after the fifth row. Rows now switch on their own
width, so the posts sit beside the Skill only when both fit, and the
carousel shows two posts where it has room.

"Earlier on this board" stays under the board. It lists Skills that left
the ranking, not earlier weeks, and it is the crawl path to every Skill
the trending sitemap lists.
@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 5, 2026
@harlan-zw

Copy link
Copy Markdown
Collaborator Author

Agent check of the rendered page. Before is production; After is the local dev server with seeded D1 data, headless Chrome. No horizontal scroll at 390, 1100, or 1440, and html-validate passed for all three ranges.

Before, 1440 After, 1440
Before at 1440 After at 1440
Before, 390 After, 390 After, dark, week
Before at 390 After at 390 After at 390, dark, week range
All time, 1440 1100: rows stack, carousel shows two posts /skills, 1440, for the shared shell
All time range at 1440 Month at 1100 /skills at 1440

@harlan-github-agent harlan-github-agent Bot added harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. and removed harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. labels Oct 5, 2026
@harlan-github-agent

harlan-github-agent Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

🤖 MERGED

Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy. Last updated: 2026-10-05 16:47 UTC.

GitHub merged this pull request.

No material findings were recorded.

The pull request closed.

@harlan-github-agent harlan-github-agent Bot added harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. and removed harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. labels Oct 5, 2026
@harlan-zw
harlan-zw merged commit 133e3c1 into main Oct 5, 2026
7 checks passed
@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. label Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant