Repository navigation
style(trending): tidy board rows, post cards and the sidebar rail - #438
Merged
Merged
Conversation
The board passed one fixed plural, "mentions in 7 days", so a Skill with one post read "1 mentions". sparkCount in shared/braille-spark.ts now picks the noun from the count, and BrailleSpark takes the window as a separate period. Both the visible count and the screen reader label use it. A day with no mentions now draws the lowest bar at 40% opacity as a track. Plain text keeps the blank cell. With blank cells, a week with one post was one bar floating in a gap before its label.
Harlan found the trending board messy. Rows were tall and did not scan: dotted rank glyphs, three-line descriptions, a run chip as wide as the column, and a second post card cut off at the board's edge. - Ranks are plain tabular mono numbers on the name's baseline. The first three are a step darker, and none is rose. - Each metadata line runs source, stars, then the signal that ranked the row. An empty slot renders nothing, and a long repository name is cut short before it pushes the signal to a second line. - Descriptions stop at two lines, and the run chip is as wide as its command. - The post carousel shows whole cards only: one, or two where it has room. The pager ends on the cards' right edge. - The sidebar invitation drops the email preview and its card. Its button is the rail's one solid rose element, so the install chip inks its dot while the invitation shows.
Contributor
🤖 MERGED
GitHub merged this pull request.
Review completed. No finding above 80/100. Selected findings run after merge and open separate pull requests. |
Collaborator
Author
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






🔗 Linked issue
Related to #433 and #431
❓ Type of change
📚 Description
Harlan found
/skills/trendingmessy after #433 moved it to the full-width shell. Rows were tall and slow to scan, a second post card was cut off at the board's edge, and a Skill with one post read "1 mentions". This change polishes the board and the sidebar. Ranking, data, routes and copy stay the same, apart from the plural fix.On each row:
sparkCountinshared/braille-spark.tspicks the noun from the count, so a spark reads "1 mention in 7 days".BrailleSparktakes the window as a separateperiodprop, and its screen reader label uses the same text. A day with no mentions now draws the lowest bar at 40% opacity as a track, so a lone bar no longer floats in a gap. The plain-text spark frombrailleSpark()keeps the blank cell.In the sidebar, the weekly invitation drops the email preview and its card, and its button is smaller. That button is the rail's one solid rose element, so the install chip under it inks its dot while the invitation shows.
SkilldInstallChipand_CommandChipgain an optionalquietprop for this, and every other chip keeps the rose dot. The invitation after the fifth row on narrow screens keeps its preview.DESIGN.mddescribes the spark track and logs the polish as a 2026-10-06 decision.Page question: what are devs talking about this week or month? Primary action: copy the run command. Owning concern: Loop 1. DESIGN motifs: PASS; the rail spends one solid rose element, and each spark keeps today in rose.