Skip to content

feat(registry): show Skill behaviors on Skill pages - #425

Merged
harlan-zw merged 3 commits into
mainfrom
feat-skill-page-behaviors
Oct 5, 2026
Merged

harlan-zw merged 3 commits into
mainfrom
feat-skill-page-behaviors

Conversation

@harlan-zw

@harlan-zw harlan-zw commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation
  • 🐞 Bug fix
  • 👌 Enhancement
  • ✨ New feature
  • 🧹 Chore
  • ⚠️ Breaking change

📚 Description

A reader deciding whether to run a Skill had only its declared allowed-tools, which most Skills leave out. The Skill page now applies the skilld CLI's own behavior rules to SKILL.md and the stored file names. It lists each behavior with links to the exact lines on GitHub and marks the ones skilld run holds for approval. The desktop rail shows the same behaviors as chips.

The page reads no supporting file content, so the panel says it checked SKILL.md and file names, and that skilld run checks every file. The rules come from skilld-protocol/behaviors (skilld-dev/skilld#195), so the site and the CLI share one rule list.

skilld-protocol dropped CliEventInputSchema in skilld-dev/skilld#148, and POST /api/events/cli was its last user. The CLI never sent those events, so this pull request removes the endpoint.

skilld 3.6.0 published skilld-protocol 2.5.0, and the last commit takes it. Only its lockfile entries change: a full re-resolve on main also moves wrangler, which belongs in its own update.

Architecture: the Skill detail route runs the shared skilld-protocol rules over SKILL.md and file names and feeds the rail and the new panel; the unused CLI event endpoint is removed

🤖 AI disclosure: Harlan Agent Kit modified this description. My AI open-source policy.

The skilld CLI never sent telemetry, and skilld-protocol dropped the
CliEventInputSchema contract in skilld-dev/skilld#148. The endpoint was
the last import of that schema, so the site could not take a newer
skilld-protocol while it stayed.
A reader asking whether a Skill is fine to run had only the declared
allowed-tools, which most Skills leave out. The Skill page now runs the
skilld CLI's own behavior rules from skilld-protocol over SKILL.md and
the stored file names, lists each behavior with links to the exact
lines, and marks the ones skilld run holds for approval.

The page reads no supporting file content, so the panel says which
inputs it checked and that skilld run checks every file.
@harlan-zw

Copy link
Copy Markdown
Collaborator Author

Agent note: checked the visible change in the running app, using production Skill data through a local proxy.

The mcp-builder page below had a sudo line added to its SKILL.md in the local preview only, so the panel shows a Needs approval row. None of the 44 sample Skills I checked matches a high-risk behavior in SKILL.md itself.

Phone, light Phone, dark Desktop rail
Phone light Phone dark Desktop rail

skilld-protocol 2.5.0 exports skilld-protocol/behaviors, which the Skill
page uses. Only its lockfile entries change; a full re-resolve on main
also moves wrangler, which belongs in its own update.
@harlan-zw
harlan-zw marked this pull request as ready for review October 5, 2026 15:24
@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 5, 2026
@harlan-github-agent harlan-github-agent Bot added harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. harlan-agent-running An Agent holds a Task on this issue or pull request right now. and removed harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. labels Oct 5, 2026
@harlan-github-agent

harlan-github-agent Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

🤖 MERGED

Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy. Last updated: 2026-10-05 16:06 UTC.

GitHub merged this pull request.

No material findings were recorded.

Another Agent took this Review.

@harlan-github-agent harlan-github-agent Bot added harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. and removed harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. labels Oct 5, 2026
@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 5, 2026
@harlan-github-agent harlan-github-agent Bot removed harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. labels Oct 5, 2026
@harlan-zw
harlan-zw merged commit 98d68e6 into main Oct 5, 2026
7 checks passed
@harlan-zw

Copy link
Copy Markdown
Collaborator Author

🤖 Harlan Agent Kit Agent assessment of head 2a84061.

The Service Review for that head failed twice with "Desktop disconnected during the Agent turn". No new Review task appeared within 20 minutes of the second request, so an independent read-only subagent reviewed the head after stop-review returned Stopped.

No finding scored above 80. b6e4cfc fixes the four highest Logged findings:

  • 75: SKILL.md line links opened GitHub's rendered preview at the top. Markdown links now use ?plain=1#L<n>.
  • 30: the detail cache key stayed v3, so pre-deploy cache entries showed "No rule matched." It is now v4.
  • 25: a Skill whose upstream file is gone linked to 404s. It now gets no links.
  • 15: the rail could link to a panel that did not render. The panel now renders whenever the rail shows.

Still Logged, unchanged: line numbers come from the last synced copy (15), nested Skills inherit child files from stored assets (15), and stored assets carry no file mode (10).

This is not a Service READY. The new head needs its own Review.

@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant