Skip to content

ci: replace deprecated markdown link check with lychee #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karakoc49 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: replace deprecated markdown link check with lychee #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions .github/workflows/package-development-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,11 @@ on:

permissions:
contents: read # required for checkout
packages: read # required for pulling the SIMATIC AX container

jobs:
build-and-test:
name: Build and Test
runs-on: ubuntu-24.04
container:
image: ghcr.io/simatic-ax/ci-images/apax-ci-image:4.3.0
credentials:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
steps:
- name: Checkout Code
uses: actions/checkout@v7
Expand All @@ -40,7 +34,6 @@ jobs:
ref: ${{ inputs.ref != '' && inputs.ref || github.ref }}

- name: Check links
uses: gaurav-nelson/github-action-markdown-link-check@v1
uses: lycheeverse/lychee-action@v2
with:
check-modified-files-only: 'yes'
base-branch: 'main'
args: --no-progress './**/*.md'
20 changes: 14 additions & 6 deletions template/.github/workflows/package-development-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,6 @@ jobs:
- name: Test source code
uses: simatic-ax/actions/apax-test@v4

- name: Check links
uses: gaurav-nelson/github-action-markdown-link-check@v1
with:
check-modified-files-only: 'yes'
base-branch: 'main'

- name: Upload build artifacts
if: ${{ github.event_name == 'workflow_call' || github.event_name == 'release'}}
uses: actions/upload-artifact@v7
Expand All @@ -94,3 +88,17 @@ jobs:
bin/llvm
retention-days: 90
if-no-files-found: error

check-links:
name: Check links
runs-on: ubuntu-24.04
steps:
- name: Checkout Code
uses: actions/checkout@v7
with:
ref: ${{ inputs.ref != '' && inputs.ref || github.ref }}

- name: Check links in Markdown files
uses: lycheeverse/lychee-action@v2
with:
args: --no-progress './**/*.md'