Repository navigation
Conversation
gaurav-nelson/github-action-markdown-link-check is deprecated. Use lycheeverse/lychee-action instead, both in this repository's workflow and in the workflow shipped with the template. The link check does not need the SIMATIC AX tooling, so it no longer runs inside the apax CI container. Fixes simatic-ax#64
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64
gaurav-nelson/github-action-markdown-link-checkis deprecated, as reported in #64. This PR replaces it withlycheeverse/lychee-action@v2, as proposed in the issue:packages: readis dropped.template/.github/workflows/…): The link check moves to a separatecheck-linksjob without the container. It doesn't need the SIMATIC AX tooling orAPAX_TOKEN, and it doesn't depend on which tools are installed in the image.Note: The old action only checked modified files. Lychee checks all Markdown files. This found one broken link:
template/README.mdlinks toLICENSE.md, which was removed fromtemplate/in 7bb1113. I assumed it is provided when an app is generated, sincetemplatify-meta-information.ymlstill lists it, so I excluded it in the repository workflow. Iftemplate/LICENSE.mdshould exist instead, I'm happy to change this.Tested on my fork: the workflow passes, with lychee checking 6 links, 0 errors and 1 excluded.
actionlintis clean for the changed parts.Related: simatic-ax/template-library#77 (same change)