Skip to content

Friglet cleanup 6/6: align docs with the combined stack (SNB-661) - #72

Merged
setavenger merged 3 commits into
integrationfrom
snb-661-stack-06-docs
Oct 11, 2026
Merged

setavenger merged 3 commits into
integrationfrom
snb-661-stack-06-docs

Conversation

@setavenger

@setavenger setavenger commented Oct 4, 2026 •

Copy link
Copy Markdown
Owner

Stacked on #71; review only this stage's commits and diff.

Purpose

Finish the cleanup stack by making the README, AGENTS.md, Docker guidance, and Dockerfile comments match the accumulated implementation. The follow-up commit also resolves the post-merge notes from the source docs PR: stdout controls daemon colour, tests no longer use the old gitignored directory, socket guidance names the control_socket config key and explains how to query an explicit path, and the documented Debian dependency list includes GTK alongside WebKit and ayatana.

The Debian list was confirmed from the accumulated stage 5 PR #71 CI artifact (Release bundles run 37126277975): libayatana-appindicator3-1, libwebkit2gtk-4.1-0, libgtk-3-0, each once. The stage 5 Linux, macOS, and Windows packaging jobs all passed; this final stage changes docs only. The result also matches the artifact recorded on original PR #48. This stage preserves the original reviewed #63 commits and authorship, then adds the scoped combined-stack follow-up for SNB-661.

Stack

  1. Predecessor: snb-661-stack-05-tray (#71)
  2. This PR: snb-661-stack-06-docs → snb-661-stack-05-tray

Included original PR: #63 (SNB-674).

Verification

Full accumulated debug gate on this exact head:

  • cargo check --workspace --all-targets --all-features: clean, 0 warnings.
  • cargo check -p blindbit-lib --no-default-features --all-targets: 5 baseline warnings, no growth.
  • cargo clippy --no-deps -p friglet -p friglet-ipc -p friglet-tray --all-targets -- -D warnings: clean.
  • cargo fmt -p friglet -p friglet-ipc -p friglet-tray -- --check: clean.
  • cargo test --workspace: 258 passed, 1 ignored, 0 failed.

Original #63 ran the documented Linux GetStatus selector against a real daemon with temporary data paths and checked explicit override and runtime-directory selection. It also built the Docker runtime stage with a debug binary. This grouped stage did not repeat those runtime checks, build a new release bundle, or build the full release Docker image.

Landing

Merge the six grouped PRs in numeric order with merge commits. After #71 lands, retarget this PR to integration, verify its base and diff, and only then merge it. Preserve the predecessor branch until this PR has been retargeted if necessary. Never merge a child PR into its feature-branch base.

setavenger and others added 3 commits October 11, 2026 20:14
Correct what the docs say about integration as it is now; no code changes.

- README: blindbit-cli needs --end-height, takes only ip:port for the P2P
  node, keeps its state in ./scanner_state.json by default and has
  --log-level; friglet's --log-level is documented; console logs go to
  stdout, not stderr; the tray build needs no appindicator/rsvg packages.
- HTTP /height and /subscribe do not answer while scanning is enabled,
  so status checks use the control socket's GetStatus or an Electrum
  server.version call instead of curl /height. The HTTP docs stay.
- Docker: the scanner state is not in /data by default (SNB-635); the docs
  and the Dockerfile comment say so and give the workaround, an absolute
  state_file under /data.
- AGENTS.md: Rust >= 1.90 (Tauri crates declare it; let-chains need 1.88),
  the packages a build actually needs vs. release bundling, blindbit-lib
  has tests, the Settings tab saves with ApplySettings, GetStatus reads a
  background poller, the default state file is per wallet, an HTTP bind
  failure panics. Past-fix narrative and repeated sections removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Use the Linux data-directory socket when XDG_RUNTIME_DIR is unset,
and prefer the explicit environment override. Document the fallback
paths and how to use a configured socket override.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Align the runtime, socket, test-fixture, and package dependency documentation with the full grouped stack.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@setavenger
setavenger force-pushed the snb-661-stack-06-docs branch from 9de55dd to 742c949 Compare October 11, 2026 18:15
@setavenger
setavenger merged commit aa3f487 into integration Oct 11, 2026
1 check passed
@setavenger
setavenger deleted the snb-661-stack-06-docs branch October 11, 2026 18:15
setavenger added a commit that referenced this pull request Oct 12, 2026
…ndex

Brings in integration (the merged deslop stack #67-#72) via snb-662-remove-full-receive-path.
No code change: this branch's tree stays the same.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant