Repository navigation
Friglet cleanup 6/6: align docs with the combined stack (SNB-661) - #72
Merged
Merged
Conversation
This was referenced Oct 11, 2026
setavenger
force-pushed
the
snb-661-stack-06-docs
branch
4 times, most recently
from
October 11, 2026 18:14
980cb61 to
9de55dd
Compare
Correct what the docs say about integration as it is now; no code changes. - README: blindbit-cli needs --end-height, takes only ip:port for the P2P node, keeps its state in ./scanner_state.json by default and has --log-level; friglet's --log-level is documented; console logs go to stdout, not stderr; the tray build needs no appindicator/rsvg packages. - HTTP /height and /subscribe do not answer while scanning is enabled, so status checks use the control socket's GetStatus or an Electrum server.version call instead of curl /height. The HTTP docs stay. - Docker: the scanner state is not in /data by default (SNB-635); the docs and the Dockerfile comment say so and give the workaround, an absolute state_file under /data. - AGENTS.md: Rust >= 1.90 (Tauri crates declare it; let-chains need 1.88), the packages a build actually needs vs. release bundling, blindbit-lib has tests, the Settings tab saves with ApplySettings, GetStatus reads a background poller, the default state file is per wallet, an HTTP bind failure panics. Past-fix narrative and repeated sections removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Use the Linux data-directory socket when XDG_RUNTIME_DIR is unset, and prefer the explicit environment override. Document the fallback paths and how to use a configured socket override. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Align the runtime, socket, test-fixture, and package dependency documentation with the full grouped stack. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
setavenger
force-pushed
the
snb-661-stack-06-docs
branch
from
October 11, 2026 18:15
9de55dd to
742c949
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #71; review only this stage's commits and diff.
Purpose
Finish the cleanup stack by making the README,
AGENTS.md, Docker guidance, and Dockerfile comments match the accumulated implementation. The follow-up commit also resolves the post-merge notes from the source docs PR: stdout controls daemon colour, tests no longer use the old gitignored directory, socket guidance names thecontrol_socketconfig key and explains how to query an explicit path, and the documented Debian dependency list includes GTK alongside WebKit and ayatana.The Debian list was confirmed from the accumulated stage 5 PR #71 CI artifact (Release bundles run 37126277975):
libayatana-appindicator3-1, libwebkit2gtk-4.1-0, libgtk-3-0, each once. The stage 5 Linux, macOS, and Windows packaging jobs all passed; this final stage changes docs only. The result also matches the artifact recorded on original PR #48. This stage preserves the original reviewed #63 commits and authorship, then adds the scoped combined-stack follow-up for SNB-661.Stack
snb-661-stack-05-tray(#71)snb-661-stack-06-docs→snb-661-stack-05-trayIncluded original PR: #63 (SNB-674).
Verification
Full accumulated debug gate on this exact head:
cargo check --workspace --all-targets --all-features: clean, 0 warnings.cargo check -p blindbit-lib --no-default-features --all-targets: 5 baseline warnings, no growth.cargo clippy --no-deps -p friglet -p friglet-ipc -p friglet-tray --all-targets -- -D warnings: clean.cargo fmt -p friglet -p friglet-ipc -p friglet-tray -- --check: clean.cargo test --workspace: 258 passed, 1 ignored, 0 failed.Original #63 ran the documented Linux
GetStatusselector against a real daemon with temporary data paths and checked explicit override and runtime-directory selection. It also built the Docker runtime stage with a debug binary. This grouped stage did not repeat those runtime checks, build a new release bundle, or build the full release Docker image.Landing
Merge the six grouped PRs in numeric order with merge commits. After #71 lands, retarget this PR to
integration, verify its base and diff, and only then merge it. Preserve the predecessor branch until this PR has been retargeted if necessary. Never merge a child PR into its feature-branch base.