Skip to content

friglet-tray: drop the outdated daemon binary rebuild hint (SNB-677) - #73

Merged
setavenger merged 1 commit into
integrationfrom
snb-677-drop-rebuild-hint
Oct 30, 2026
Merged

setavenger merged 1 commit into
integrationfrom
snb-677-drop-rebuild-hint

Conversation

@setavenger

@setavenger setavenger commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

Stacked on #72 (snb-661-stack-06-docs, top of the Friglet cleanup stack #67–#72); review only the commit after it. Retargets to integration once #67–#72 land.

Implements SNB-677, decided by the maintainer on 2026-10-11. Net −42 lines.

What goes, and why

When a daemon the tray spawned exited straight away and its output looked like a clap usage dump (Usage: … <COMMAND>), the tray appended "the daemon binary at … is an outdated build that requires CLI arguments; rebuild it (cargo build --release -p friglet) …" to the "Daemon: unreachable" reason. That pattern is a friglet build from before 20 July 2026 (bb79546 made the scan subcommand optional), which still required the scan subcommand. No release or tag was ever published with that CLI, so only a developer's own stale local build could hit it.

  • friglet-tray/src/lifecycle.rs: the usage-dump sniff and the appended hint.
  • friglet-tray/tests/lifecycle_e2e.rs: stale_binary_usage_output_gets_rebuild_hint, the test of that hint.
  • friglet-tray/tests/fixtures/stale-friglet.sh: the fixture only that test used.

What a stale binary shows now

The same as any other immediate exit: spawned daemon exited immediately (exit status: 2): <the daemon's captured output> (unlevelled lines such as a usage dump count as errors and are joined with " | "). The daemon's own output is still captured and summarised (failure_summary), and spawn_failure_surfaces_captured_stderr still covers that. recent_output_tail stays; the Status tab's crash card and crash error message use it. The AGENTS.md troubleshooting note ("an immediate exit with status 2 is clap rejecting the arguments, most likely a stale friglet binary; rebuild it") stays because it is still true.

Reviews

  • gstack review: ship; three wording fixes in this description, applied.
  • thermo-nuclear-review: ship, no findings. The reason no longer names the binary path (only the removed hint did); the path is still in the tray's "spawned friglet daemon" info log and in the "failed to spawn" reason.

Verification

  • cargo test --workspace: 257 passed, 1 ignored, 0 failed (base: 258 / 1; the difference is the removed test).
  • cargo clippy --no-deps -p friglet -p friglet-ipc -p friglet-tray --all-targets -- -D warnings: clean.
  • cargo fmt -p friglet -p friglet-ipc -p friglet-tray -- --check: clean.
  • cargo check --workspace --all-targets --all-features: 0 warnings.

@setavenger
setavenger added this pull request to stack #77 October 11, 2026 12:17
@setavenger
setavenger force-pushed the snb-677-drop-rebuild-hint branch 5 times, most recently from 044a040 to e6a4129 Compare October 11, 2026 18:15
Base automatically changed from snb-661-stack-06-docs to integration October 11, 2026 18:15
The tray appended a "rebuild it" hint when a spawned daemon exited with a
clap usage dump, the signature of a friglet build from before July 2026
that still required the `scan` subcommand. No release or tag was ever
published with that CLI, so only a developer's own stale local build could
hit it. The daemon's captured output is still shown in the reason, as for
any other immediate exit.

Removes the hint, its e2e test and the stale-binary fixture script.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@setavenger
setavenger force-pushed the snb-677-drop-rebuild-hint branch from e6a4129 to e0e2c22 Compare October 11, 2026 18:15
@setavenger
setavenger merged commit c579cca into integration Oct 30, 2026
1 check passed
@setavenger
setavenger deleted the snb-677-drop-rebuild-hint branch October 30, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant