Repository navigation
friglet-tray: drop the outdated daemon binary rebuild hint (SNB-677) - #73
Merged
Merged
Conversation
setavenger
force-pushed
the
snb-677-drop-rebuild-hint
branch
5 times, most recently
from
October 11, 2026 18:15
044a040 to
e6a4129
Compare
The tray appended a "rebuild it" hint when a spawned daemon exited with a clap usage dump, the signature of a friglet build from before July 2026 that still required the `scan` subcommand. No release or tag was ever published with that CLI, so only a developer's own stale local build could hit it. The daemon's captured output is still shown in the reason, as for any other immediate exit. Removes the hint, its e2e test and the stale-binary fixture script. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
setavenger
force-pushed
the
snb-677-drop-rebuild-hint
branch
from
October 11, 2026 18:15
e6a4129 to
e0e2c22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #72 (
snb-661-stack-06-docs, top of the Friglet cleanup stack #67–#72); review only the commit after it. Retargets tointegrationonce #67–#72 land.Implements SNB-677, decided by the maintainer on 2026-10-11. Net −42 lines.
What goes, and why
When a daemon the tray spawned exited straight away and its output looked like a clap usage dump (
Usage:…<COMMAND>), the tray appended "the daemon binary at … is an outdated build that requires CLI arguments; rebuild it (cargo build --release -p friglet) …" to the "Daemon: unreachable" reason. That pattern is a friglet build from before 20 July 2026 (bb79546made thescansubcommand optional), which still required thescansubcommand. No release or tag was ever published with that CLI, so only a developer's own stale local build could hit it.friglet-tray/src/lifecycle.rs: the usage-dump sniff and the appended hint.friglet-tray/tests/lifecycle_e2e.rs:stale_binary_usage_output_gets_rebuild_hint, the test of that hint.friglet-tray/tests/fixtures/stale-friglet.sh: the fixture only that test used.What a stale binary shows now
The same as any other immediate exit:
spawned daemon exited immediately (exit status: 2): <the daemon's captured output>(unlevelled lines such as a usage dump count as errors and are joined with " | "). The daemon's own output is still captured and summarised (failure_summary), andspawn_failure_surfaces_captured_stderrstill covers that.recent_output_tailstays; the Status tab's crash card and crash error message use it. The AGENTS.md troubleshooting note ("an immediate exit with status 2 is clap rejecting the arguments, most likely a stalefrigletbinary; rebuild it") stays because it is still true.Reviews
review: ship; three wording fixes in this description, applied.thermo-nuclear-review: ship, no findings. The reason no longer names the binary path (only the removed hint did); the path is still in the tray's "spawned friglet daemon" info log and in the "failed to spawn" reason.Verification
cargo test --workspace: 257 passed, 1 ignored, 0 failed (base: 258 / 1; the difference is the removed test).cargo clippy --no-deps -p friglet -p friglet-ipc -p friglet-tray --all-targets -- -D warnings: clean.cargo fmt -p friglet -p friglet-ipc -p friglet-tray -- --check: clean.cargo check --workspace --all-targets --all-features: 0 warnings.