Repository navigation
Friglet cleanup 1/6: stabilize tests and builds (SNB-661) - #67
Merged
Merged
Conversation
blindbit-lib depended on silentpayments, prost-types and (through the serde feature) base64 without using any of them. silentpayments alone pulled 8 packages into the build, among them a second libsecp256k1 C build and a git fetch. Cargo.lock goes from 635 to 627 packages. Also remove manifest lines that repeat Cargo's defaults or are commented out: blindbit-lib's [[example]] blocks (auto-discovered from examples/), blindbit-cli's [[bin]] block, friglet's empty [features] table, the serde feature and package key on friglet's bdk_sp (friglet only uses SilentPaymentCode; blindbit-lib enables bdk_sp/serde anyway), and a commented-out [profile.release] in the workspace manifest. No code changes; the build targets and features cargo metadata reports are the same apart from base64 leaving blindbit-lib's serde feature. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Three lifecycle e2e tests wrote a shell script to a temp dir and then ran it as the "daemon binary". The test harness runs tests on parallel threads of one process, so another test's spawn could fork while the script was still open for writing; the forked child holds that write handle until it execs, and running the script in that window fails with "Text file busy" (ETXTBSY, os error 26). The scripts are now committed as executable fixtures under friglet-tray/tests/fixtures/ and located via CARGO_MANIFEST_DIR, so nothing is written while the tests run. The long-running fixture uses `exec sleep 30`, so killing the spawned child no longer leaves a stray sleep behind for 30 s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
release.yml pinned TAURI_CLI_VERSION 2.11.5, but Cargo.lock moved the tauri crate to 2.12.1 in 8bf4c40, against the workflow's own rule to keep the two equal. tauri 2.12.1 was released from the same commit (30da1fd in tauri-apps/tauri) as tauri-cli and @tauri-apps/cli 2.12.1, together with tauri-utils 2.10.1 and tauri-build 2.7.1, which are also the versions in Cargo.lock. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The test and clippy job installed libayatana-appindicator3-dev, librsvg2-dev, libssl-dev and patchelf, but nothing in the test build uses them: Cargo.lock has no openssl or rsvg crates, libappindicator-sys loads the library at run time (libloading, no build script linking it), and patchelf is only used for AppImage bundles. release.yml keeps its list: tauri build bundles appindicator. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`features = []` on the tauri-build build dependency is Cargo's default; the plain version requirement means the same. Cargo.lock is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Preserve the reviewed SNB-678 changes as the first foundation stage. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Preserve the reviewed SNB-684 changes in the foundation stage. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Preserve the reviewed SNB-670 changes in the foundation stage. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Preserve the reviewed SNB-675 changes in the foundation stage. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 11, 2026
setavenger
added a commit
that referenced
this pull request
Oct 30, 2026
Brings #18 up to date with master after the Friglet Deslop cleanup (#67-#76). Conflicts resolved as described in #75: - blindbit-lib/Cargo.toml, friglet/Cargo.toml: keep #18's bdk-sp rev pin and comments on top of the reduced manifest lines from SNB-670. - scanning.rs: BIP352_K_MAX loses its #[expect(dead_code)] (the compile-time assert against bdk_sp::K_MAX now uses it); its doc no longer mentions the removed scan_transaction_full, which stays deleted. - bip352_vectors.rs: the full-path K_max boundary test stays deleted; the live K_max test takes the label set and imports BIP352_K_MAX; its doc no longer links the deleted test. - Cargo.toml: the secp256k1-sys comment no longer says the live K_max test is ignored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
setavenger
added a commit
that referenced
this pull request
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Establish the cleanup stack on a stable build and test foundation. This stage makes the tray lifecycle fixtures deterministic, pins the Tauri CLI to the locked crate version, removes unused manifest entries and dependencies, and trims CI packages that the workspace checks do not use.
This preserves the original reviewed commits and their authorship through merge commits. It is the first of six cumulative stages for SNB-661.
Stack
snb-661-stack-01-foundation→integrationsnb-661-stack-02-libraryIncluded original PRs, in merge order: #45 (SNB-678), #49 (SNB-684), #43 (SNB-670), #50 (SNB-675).
Verification
Full accumulated debug gate on this exact head:
cargo check --workspace --all-targets --all-features: clean, 0 warnings.cargo check -p blindbit-lib --no-default-features --all-targets: 5 baseline warnings, no growth.cargo clippy --no-deps -p friglet -p friglet-ipc -p friglet-tray --all-targets -- -D warnings: clean.cargo fmt -p friglet -p friglet-ipc -p friglet-tray -- --check: clean.cargo test --workspace: 254 passed, 1 ignored, 0 failed.The lifecycle e2e suite ran as part of the combined gate: 9 passed. Original #49 and #50 CI also exercised the release pin and reduced CI package set. No new grouped release bundle or interactive tray runtime check was performed.
Landing
Merge the six grouped PRs in numeric order with merge commits. After this PR lands, retarget stage 2 to
integration, verify its base and diff, and only then merge it. Preserve this branch until stage 2 has been retargeted if GitHub does not do so safely. Never merge a child PR into its feature-branch base.