Skip to content

ci: stop installing packages the tests do not need (SNB-675) - #50

Merged
setavenger merged 1 commit into
integrationfrom
snb-675-ci-fewer-packages
Oct 11, 2026
Merged

setavenger merged 1 commit into
integrationfrom
snb-675-ci-fewer-packages

Conversation

@setavenger

@setavenger setavenger commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner

Implements SNB-675.

What was removed and why

The test job in .github/workflows/ci.yml stops installing four packages that nothing in the test or clippy build uses:

  • libssl-dev: Cargo.lock has no openssl / openssl-sys crate.
  • librsvg2-dev: no rsvg crate in Cargo.lock.
  • libayatana-appindicator3-dev: libappindicator-sys has no build script that links it. It loads the library at run time through libloading, and the tray uses the KSNI backend anyway.
  • patchelf: only the AppImage bundler uses it, and CI does not bundle.

release.yml keeps its full list, because tauri build bundles appindicator.

Behaviour

CI only. The job still installs what the workspace build needs: GTK, WebKitGTK, protobuf, pkg-config. This PR's own CI run is not proof on its own: it restored a warm Rust cache, so the dependency build scripts did not re-run. The evidence is a check of every system-library lookup in the build: the GTK/WebKit -sys crates need only what libgtk-3-dev and libwebkit2gtk-4.1-dev provide, libdbus-sys gets dbus-1 through libgtk-3-dev, libappindicator-sys has no build script, and no openssl or rsvg crate is in the build. A cold-cache run will confirm it the first time the cache key changes.

Verification

  • This PR's CI run is the check (see the checks below). I will add the install-step time of this run in a comment.
  • Install step before, from recent runs: 47 s (integration push, run 37023307942), 47 s (37023278352), 36 s (37013832333), 72 s (37012374048).
  • Pre-push suite on this branch (the Rust tree is the same as integration): cargo check --workspace --all-targets --all-features 0 warnings; clippy -D warnings clean; fmt clean; cargo test --workspace 254 passed, 1 ignored, 0 failed.

The test and clippy job installed libayatana-appindicator3-dev,
librsvg2-dev, libssl-dev and patchelf, but nothing in the test build
uses them: Cargo.lock has no openssl or rsvg crates,
libappindicator-sys loads the library at run time (libloading, no build
script linking it), and patchelf is only used for AppImage bundles.
release.yml keeps its list: tauri build bundles appindicator.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@setavenger

Copy link
Copy Markdown
Owner Author

CI is green on this PR (run 37111494563). The "Install system dependencies" step took 23 s here.

With the full package list, the same step took 40 s (#48, run 37111322432), 32 s (#49, run 37111418615) and 39 s (#45, run 37110836396) in the same half hour. Earlier runs on integration took 36 to 72 s. So the step is about 10 to 17 s shorter per run (roughly 40%) when compared within the same half hour.

@setavenger
setavenger merged commit 839c35e into integration Oct 11, 2026
1 check passed
@setavenger
setavenger deleted the snb-675-ci-fewer-packages branch October 11, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant