Repository navigation
ci: stop installing packages the tests do not need (SNB-675) - #50
Merged
Merged
Conversation
The test and clippy job installed libayatana-appindicator3-dev, librsvg2-dev, libssl-dev and patchelf, but nothing in the test build uses them: Cargo.lock has no openssl or rsvg crates, libappindicator-sys loads the library at run time (libloading, no build script linking it), and patchelf is only used for AppImage bundles. release.yml keeps its list: tauri build bundles appindicator. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
CI is green on this PR (run 37111494563). The "Install system dependencies" step took 23 s here. With the full package list, the same step took 40 s (#48, run 37111322432), 32 s (#49, run 37111418615) and 39 s (#45, run 37110836396) in the same half hour. Earlier runs on integration took 36 to 72 s. So the step is about 10 to 17 s shorter per run (roughly 40%) when compared within the same half hour. |
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements SNB-675.
What was removed and why
The
testjob in.github/workflows/ci.ymlstops installing four packages that nothing in the test or clippy build uses:libssl-dev: Cargo.lock has noopenssl/openssl-syscrate.librsvg2-dev: norsvgcrate in Cargo.lock.libayatana-appindicator3-dev:libappindicator-syshas no build script that links it. It loads the library at run time throughlibloading, and the tray uses the KSNI backend anyway.patchelf: only the AppImage bundler uses it, and CI does not bundle.release.ymlkeeps its full list, becausetauri buildbundles appindicator.Behaviour
CI only. The job still installs what the workspace build needs: GTK, WebKitGTK, protobuf, pkg-config. This PR's own CI run is not proof on its own: it restored a warm Rust cache, so the dependency build scripts did not re-run. The evidence is a check of every system-library lookup in the build: the GTK/WebKit
-syscrates need only whatlibgtk-3-devandlibwebkit2gtk-4.1-devprovide,libdbus-sysgetsdbus-1throughlibgtk-3-dev,libappindicator-syshas no build script, and no openssl or rsvg crate is in the build. A cold-cache run will confirm it the first time the cache key changes.Verification
cargo check --workspace --all-targets --all-features0 warnings; clippy-D warningsclean; fmt clean;cargo test --workspace254 passed, 1 ignored, 0 failed.